From: "Gary Guo" <gary@garyguo.net>
To: "Danilo Krummrich" <dakr@kernel.org>, <aliceryhl@google.com>,
<airlied@gmail.com>, <simona@ffwll.ch>,
<daniel.almeida@collabora.com>, <ojeda@kernel.org>,
<boqun@kernel.org>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
<a.hindborg@kernel.org>, <tmgross@umich.edu>, <tamird@kernel.org>,
<acourbot@nvidia.com>, <work@onurozkan.dev>
Cc: <nova-gpu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] rust: drm: remove DRM device private data
Date: Fri, 20 Nov 2026 11:23:29 +0000 [thread overview]
Message-ID: <DN00073G4YPY.140V1WRMQEK1I@garyguo.net> (raw)
In-Reply-To: <20261118181245.2583303-1-dakr@kernel.org>
On Wed Nov 18, 2026 at 6:07 PM GMT, Danilo Krummrich wrote:
> Driver::Data is owned by the reference-counted drm::Device and can
> outlive device unregistration and driver unbind. Driver state belongs in
> RegistrationData, whose lifetime ends with registration teardown.
>
> The intended model is that, after drm_dev_unplug(), surviving DRM
> objects (e.g. through remaining userspace handles) no longer require
> access to the driver state. Thus Driver::RegistrationData is available
> (and sufficient) for all DRM callbacks into the driver.
>
> Remove Driver::Data, its storage and Deref implementation, and the
> unused workqueue implementations that depend on it. Drop the data
> initializer argument from UnregisteredDevice::new() and update its
> callers.
>
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
With the const assert added:
Reviewed-by: Gary Guo <gary@garyguo.net>
> ---
> drivers/gpu/drm/nova/driver.rs | 3 +-
> drivers/gpu/drm/tyr/driver.rs | 3 +-
> rust/kernel/drm/device.rs | 128 ++-------------------------------
> rust/kernel/drm/driver.rs | 3 -
> rust/kernel/drm/gem/shmem.rs | 6 +-
> 5 files changed, 9 insertions(+), 134 deletions(-)
prev parent reply other threads:[~2026-11-20 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 18:07 Danilo Krummrich
2026-11-19 11:17 ` Alice Ryhl
2026-11-19 11:24 ` Gary Guo
2026-11-19 11:49 ` Alice Ryhl
2026-11-19 17:28 ` Danilo Krummrich
2026-11-20 9:53 ` Alice Ryhl
2026-11-20 11:23 ` Gary Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DN00073G4YPY.140V1WRMQEK1I@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®