mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Brophy <Professor_jonny@hotmail.com>
To: Andriy Shevencho <andriy.shevchenko@linux.intel.com>,
	Jonathan Brophy <professorjonny98@gmail.com>
Cc: lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Radoslav Tsvetkov <rtsvetkov@gradotech.eu>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v5 7/7] leds: Add virtual LED group driver
Date: Sat, 3 Jan 2026 08:22:06 +0000	[thread overview]
Message-ID: <DS0PR84MB3746506E7740C032585F124F9FB8A@DS0PR84MB3746.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <aVPDUVNX95Hv13VU@smile.fi.intel.com>


>I stopped with this, this patch is half-baked and unreviewable. Please, split
>it to a few features and add one-by-one, for example:

>- very basic sypport
>- feature A
>- ...
>- debugfs

>So I expect 3+ patches out of this one. And try to keep size of a change less
>than 1000 LoCs.

Thanks Andy

You have given me some things to fix and some great advice I'm a very junior dev and
I know nothing of the led subsystem before this project.

I think it may be best to use a function to generate a gamma table I was thinking a
hard coded table may be a better idea for performance reasons with addressable rgb
strips that I plan to implement in the future.

I planned to split the driver into several files is this what you mean?
it would logically break into  files as part of the driver as follows:

core.c
arbitration.c
phys.c
vled.c
debugfs.c
virtualcolor.h

Regards
Jonathan Brophy

  reply	other threads:[~2026-01-03  8:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-30  8:23 [PATCH v5 0/7] leds: Add virtual LED group driver with priority arbitration Jonathan Brophy
2025-12-30  8:23 ` [PATCH v5 1/7] dt-bindings: leds: add function virtual_status to led common properties Jonathan Brophy
2025-12-30  8:23 ` [PATCH v5 2/7] dt-bindings: leds: Add virtual LED class bindings Jonathan Brophy
2025-12-30  8:23 ` [PATCH v5 3/7] dt-bindings: leds: Add virtual LED group controller bindings Jonathan Brophy
2025-12-30  8:23 ` [PATCH v5 4/7] ABI: Add sysfs documentation for leds-group-virtualcolor Jonathan Brophy
2025-12-30 11:52   ` Andriy Shevencho
2025-12-30  8:23 ` [PATCH v5 5/7] leds: Add driver " Jonathan Brophy
2025-12-30  8:23 ` [PATCH v5 6/7] leds: Add fwnode_led_get() for firmware-agnostic LED resolution Jonathan Brophy
2025-12-30 12:00   ` Andriy Shevencho
2025-12-31  2:30   ` kernel test robot
2025-12-31 23:37   ` kernel test robot
2025-12-31 23:45   ` kernel test robot
2026-01-02 12:20   ` kernel test robot
2026-01-02 15:07   ` kernel test robot
2026-01-02 16:29   ` kernel test robot
2025-12-30  8:23 ` [PATCH v5 7/7] leds: Add virtual LED group driver with priority arbitration Jonathan Brophy
2025-12-30 12:19   ` Andriy Shevencho
2026-01-03  8:22     ` Jonathan Brophy [this message]
2026-01-03 12:56       ` [PATCH v5 7/7] leds: Add virtual LED group driver Andriy Shevencho
2026-01-06 16:59 ` [PATCH v5 0/7] leds: Add virtual LED group driver with priority arbitration Rob Herring
2026-01-13 11:52   ` Lee Jones
2026-01-13 11:57 ` Lee Jones
2026-01-13 20:35   ` Jonathan Brophy
2026-01-15 15:07     ` Lee Jones
2026-01-15 16:58       ` Andriy Shevencho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DS0PR84MB3746506E7740C032585F124F9FB8A@DS0PR84MB3746.NAMPRD84.PROD.OUTLOOK.COM \
    --to=professor_jonny@hotmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=professorjonny98@gmail.com \
    --cc=robh@kernel.org \
    --cc=rtsvetkov@gradotech.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®