RE: [PATCH 3/5] dt-bindings: leds: Add YAML bindings for Virtual Color LED Group driver

[Jonathan Brophy <professor_jonny@hotmail.com>]

-----Original Message-----
From: Rob Herring <robh@kernel.org> 
Sent: Tuesday, 23 September 2025 4:45 AM
To: Jonathan Brophy <professorjonny98@gmail.com>
Cc: lee Jones <lee@kernel.org>; Pavel Machek <pavel@kernel.org>; Jonathan Brophy <professor_jonny@hotmail.com>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Radoslav Tsvetkov <rtsvetkov@gradotech.eu>; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-leds@vger.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: leds: Add YAML bindings for Virtual Color LED Group driver

On Tue, Sep 16, 2025 at 11:02:15PM +1200, Jonathan Brophy wrote:
> From: Jonathan Brophy <professor_jonny@hotmail.com>
> 
> Document Virtual Color device tree bindings.
> 
> Co-developed-by: Radoslav Tsvetkov <rtsvetkov@gradotech.eu>
> Signed-off-by: Jonathan Brophy <professor_jonny@hotmail.com>
> ---
>  .../leds/leds-group-virtualcolor.yaml         | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml b/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml
> new file mode 100644
> index 000000000..945058415
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-group-virtualcolor.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/leds/leds-group-virtualcolor.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +title: Virtual LED Group with Priority Control
> +
> +maintainers:
> +  - Radoslav Tsvetkov <rtsvetkov@gradotech.eu>
> +
> +description: |
> +  Virtual LED group driver that combines multiple monochromatic LEDs into logical
> +  groups with priority-based control. The driver ensures only the highest-priority
> +  LED state is active at any given time.

> Isn't this what the multi-led binding already does?

Yes, but I think the virtual colour driver needs its own unique bindings to distinguish it from other multi color (RGB) LEDs as it is not a multicolor or RGB  LED, it can be thought of an array of LEDs exposed as a virtual single LED.

The multi-led from my understanding is more about combining control to modify and control the colour from SYSFS.

In this driver the colour is set from the device tree by combing LEDs of different colours if they are combined into a single element but it is not its sole purpose, it could be used to drive every single LED on power up for example.

If you think it is unnecessary I can remove it, but I think it would be better to differentiate it from a multi-led as I don't think they are the same.