From: "Luck, Tony" <tony.luck@intel.com>
To: Ingo Molnar <mingo@kernel.org>,
Christian Ludloff <ludloff@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Pi, Xiange" <xiange.pi@intel.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"H. Peter Anvin" <hpa@zytor.com>,
John Ogness <john.ogness@linutronix.de>,
"Ahmed S. Darwish" <darwi@linutronix.de>,
"x86-cpuid@lists.linux.dev" <x86-cpuid@lists.linux.dev>,
"x86@kernel.org" <x86@kernel.org>
Subject: RE: [PATCH -v2] x86/cpu: Add CPU model number for Bartlett Lake CPUs with Raptor Cove cores
Date: Mon, 14 Apr 2025 16:21:37 +0000 [thread overview]
Message-ID: <DS7PR11MB60779A14A91C73D04CC60494FCB32@DS7PR11MB6077.namprd11.prod.outlook.com> (raw)
In-Reply-To: <Z_0oWnbcjsekHXJd@gmail.com>
> > Please fix this. It has the core and the product reversed. That is, it
> > should be INTEL_BARTLETTLAKE and /* Raptor Cove */ to match
> > the bulk of that file.
>
> I switched it around for this commit - see the updated patch below.
>
> > And yes, you also want to fix this for INTEL_PANTHERCOVE_X
> > and /* Diamond Rapids */ entry.
> >
> > The macros refer to products.
> > The comments refer to cores.
>
> Please send a patch if you have the time.
>
> > Consistency, please.
> > Sanity, please.
>
> Amen!
PeterZ has been very vocal that he wants the "sane" way to be making the "#define"
name be based on the core rather than the product. That way multiple products using
the same core show up together in switch statements for model specific features like
power and performance counters.
This does mean we have a transition between legacy names that were using the
SoC product codename and modern ones that use the core codename.
Can the X86 maintainers please get in a huddle and define a naming
policy. This discussion keeps happening.
-Tony
next prev parent reply other threads:[~2025-04-14 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 14:31 [tip: x86/urgent] " Christian Ludloff
2025-04-14 15:23 ` [PATCH -v2] " Ingo Molnar
2025-04-14 16:21 ` Luck, Tony [this message]
2025-04-14 19:18 ` Christian Ludloff
2025-04-14 19:12 ` Christian Ludloff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS7PR11MB60779A14A91C73D04CC60494FCB32@DS7PR11MB6077.namprd11.prod.outlook.com \
--to=tony.luck@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=darwi@linutronix.de \
--cc=hpa@zytor.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ludloff@gmail.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=x86-cpuid@lists.linux.dev \
--cc=x86@kernel.org \
--cc=xiange.pi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®