From: "Eric Gonçalves" <ghatto404@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
Date: Sun, 28 Sep 2025 04:21:51 -0300 [thread overview]
Message-ID: <E0197AFC-D605-449B-BAA5-AEA0F6C52413@gmail.com> (raw)
In-Reply-To: <oi6hdvxqcble4qikfngpqc43glf6nwl24oh2ukdqwautbt4jui@geuzqecdqgsv>
On September 28, 2025 3:11:16 AM GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Sun, Sep 28, 2025 at 04:45:33AM +0000, Eric Gonçalves wrote:
>> The S20 series has additional reserved pins for the fingerprint sensor,
>> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>>
>> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>> ---
>> Changes in v2:
>> - Fixed the formatting of the <40 4> line
>> - Added Fixes tag
>> ---
>> arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> index 96662bf9e527..a87e3d23e3e2 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> @@ -159,7 +159,8 @@ &pon_resin {
>> };
>>
>> &tlmm {
>> - gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
>> + gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
>> + <40 4>, /* Unused */
>
>This is still not aligned to the opening angle bracket. Could you please
>recheck your setup?
Yeah, sorry, I had it set to 4 spaces still - I sent a v3.
>
>> };
>>
>> &usb_1 {
>> --
>> 2.51.0
>>
>
next prev parent reply other threads:[~2025-09-28 7:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 4:45 Eric Gonçalves
2025-09-28 6:11 ` Dmitry Baryshkov
2025-09-28 7:21 ` Eric Gonçalves [this message]
2025-10-01 8:48 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E0197AFC-D605-449B-BAA5-AEA0F6C52413@gmail.com \
--to=ghatto404@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®