From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82F0C1A08CA; Tue, 25 Mar 2025 13:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742908179; cv=pass; b=JXuJ9lr/yXHtTpMz0HV7Doj8tRVXwig9PkFpRnIfF4YOYm382KC5UzwDToInVjh9kBFlkujpHI+rZoGNwJSANasQVa/vhgpdEm1OR7SpjvnHYtXUTlzrGeY8HNbKpSLA+vBjefqtgSCDygBsCB9GtCFwz5BVew7tVWNBlwnL+iM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742908179; c=relaxed/simple; bh=qC4l4nPLUTUaBmleI7UPp73e252CkmVXUnVVOP0EV64=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=ckxM8sQPDt0vbs0N4UAAgmx/HxP7HUDES6xRtJBHUFfHTY6Z8TKza0RA8GgERlJYbM5lCZuJ6uOyZW6GbK5UUIBD2amaay+gBgm+VSMFGzp7MRmnwPqQHJ6r5nB0hfMEkhJnGtlqA6ZakyTCAt992IRd9sIhlO1hakjL/mQwBK0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=MYmsZL+U; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="MYmsZL+U" ARC-Seal: i=1; a=rsa-sha256; t=1742908142; cv=none; d=zohomail.com; s=zohoarc; b=DEE7M+6DmoZWacTR1YwipsLkVotmNDPAMQcKWj5XQDYddHmrb5najhjuIG8+ptuKP8s7yJczhZqmCda6aX+FViygjdkVKuXYuwLqnuigiyY7JYco8SKK28zNknP8WOjczlmiHC8y3V46fIYHNTeZ3p6kwrvK4Pb4ZVQ4DvIABZQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1742908142; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=loSLMFB/IK10Jq3RhR5KxRAIMn6HEZPEdIlCTq/6jts=; b=SNCVvKQucVOW962iVCqqEqzoY9iX7BJ3NH2/c90Rhlt17G65X77EdLVUS7tOR062kPVgC823GV0a5UQjS4il6szbTASU6kahzkiuRxHYbGK6foQNLmEEIQ5pN5mah9Jk5wLiw/Lf5ooY5isjfjWQM81dRHk6SYy2SRYIHCzxDQk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1742908142; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=loSLMFB/IK10Jq3RhR5KxRAIMn6HEZPEdIlCTq/6jts=; b=MYmsZL+UzosObPezDG7LFquTZ3PEdzao3JSj9QXecy4V9s7axf9ewD0xQk/PPsGC ADqJRQyApSzzJNpJVfFJ9CwjF5tVxhAr7yYMn97GpS6YIaFhxYjYsbk0e8rRNdev+fl RNgejQK7KBVuX3/SKYQDCfKoENk62joBMZFT+dhA= Received: by mx.zohomail.com with SMTPS id 1742908138934887.6151181162378; Tue, 25 Mar 2025 06:08:58 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: [PATCH v4 01/11] scripts: generate_rust_analyzer.py: add missing whitespace From: Daniel Almeida In-Reply-To: <20250322-rust-analyzer-host-v4-1-1f51f9c907eb@gmail.com> Date: Tue, 25 Mar 2025 10:08:42 -0300 Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Boris-Chengbiao Zhou , Kees Cook , Fiona Behrens , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Wirth Content-Transfer-Encoding: quoted-printable Message-Id: References: <20250322-rust-analyzer-host-v4-0-1f51f9c907eb@gmail.com> <20250322-rust-analyzer-host-v4-1-1f51f9c907eb@gmail.com> To: Tamir Duberstein X-Mailer: Apple Mail (2.3826.400.131.1.6) X-ZohoMailClient: External > On 22 Mar 2025, at 10:23, Tamir Duberstein wrote: >=20 > Add a space before the `/` operator for consistency with surrounding > code and code formatting tools. Add a second newline between top-level > items in accordance with PEP 8[1]: >=20 >> Surround top-level function and class definitions with two blank > lines. >=20 > This change was made by a code formatting tool. >=20 > Link: https://peps.python.org/pep-0008/ [1] > Reviewed-by: Fiona Behrens > Signed-off-by: Tamir Duberstein > --- > scripts/generate_rust_analyzer.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/scripts/generate_rust_analyzer.py = b/scripts/generate_rust_analyzer.py > index a0e5a0aef444..fc1788764b31 100755 > --- a/scripts/generate_rust_analyzer.py > +++ b/scripts/generate_rust_analyzer.py > @@ -118,7 +118,7 @@ def generate_crates(srctree, objtree, sysroot_src, = external_src, cfgs): > ): > append_crate( > display_name, > - srctree / "rust"/ display_name / "lib.rs", > + srctree / "rust" / display_name / "lib.rs", > deps, > cfg=3Dcfg, > ) > @@ -193,5 +193,6 @@ def main(): >=20 > json.dump(rust_project, sys.stdout, sort_keys=3DTrue, indent=3D4) >=20 > + > if __name__ =3D=3D "__main__": > main() >=20 > --=20 > 2.48.1 >=20 >=20 Reviewed-by: Daniel Almeida