Re: [PATCH][UPDATE] rtc: Added support for ds1672 control

[Kumar Gala <galak@kernel.crashing.org>]

On Mar 28, 2006, at 5:48 PM, Alessandro Zummo wrote:

> On Tue, 28 Mar 2006 16:55:01 -0600 (CST)
> Kumar Gala <galak@kernel.crashing.org> wrote:
>
>> +/* following are the sysfs callback functions */
>> +static ssize_t show_control(struct device *dev, struct  
>> device_attribute *attr, char *buf)
>> +{
>> +	struct i2c_client *client = to_i2c_client(dev);
>> +	char *state = "enabled";
>> +	u8 control;
>> +	int err;
>> +
>> +	err = ds1672_get_control(client, &control);
>> +	if (err)
>> +		return err;
>
>  shouldn't this be
>  if (err < 0)
> 	return err;

It could be, but doesn't need to.  ds1672_get_control either returns  
0 (success) or non-zero (-EIO) for failure.

>> +	/* read control register */
>> +	err = ds1672_get_control(client, &control);
>> +	if (err) {
>> +		dev_err(&client->dev, "%s: read error\n", __FUNCTION__);
>> +		goto exit_detach;
>> +	}
>
>  ditto.

ditto.

- kumar