From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: randy.dunlap@intel.com (Randy Dunlap)
Cc: torvalds@transmeta.com (torvalds@transmeta.com),
rmk@arm.linux.org.uk, linux-kernel@vger.kernel.org (lkml)
Subject: Re: [Fwd: 2.4.0-test12-pre7]
Date: Thu, 7 Dec 2000 16:30:35 +0000 (GMT) [thread overview]
Message-ID: <E1443wL-0002dX-00@the-village.bc.nu> (raw)
In-Reply-To: <3A2FB558.C4C13106@intel.com> from "Randy Dunlap" at Dec 07, 2000 08:05:44 AM
> I think that Linus's patch is correct and that
> pci/setup_res.c::pdev_enable_device() shouldn't be doing this:
>
> /* ??? Always turn on bus mastering. If the device doesn't support
> it, the bit will go into the bucket. */
> cmd |= PCI_COMMAND_MASTER;
>
> First, the ??? makes it iffy.
I would agree. There is hardware you need to enable, reset, configure and
then enable the master bit on otherwise it simply starts spraying random
memory addresses with bus master transfers from uninitialised hardware
registers
> by a soft boot), then the device still knows some memory addresses
> to DMA into, but it shouldn't be using those. This is addressed
Yep. Seen that happen with amd pcnet32 stuff when net booting. The net
booter left the chip prattling into main memory, not pretty
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2000-12-07 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-07 16:05 Randy Dunlap
2000-12-07 16:30 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1443wL-0002dX-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@intel.com \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®