From: Rusty Russell <rusty@linuxcare.com.au>
To: "David S. Miller" <davem@redhat.com>
Cc: schu@schu.net
Cc: linux-kernel@vger.kernel.org, rusty@linuxcare.com.au
Subject: Re: PROBLEM: 2.4.0 Kernel Fails to compile when CONFIG_IP_NF_FTP is selected
Date: Sat, 06 Jan 2001 13:40:35 +1100 [thread overview]
Message-ID: <E14EjHY-0005jK-00@halfway> (raw)
In-Reply-To: Your message of "Fri, 05 Jan 2001 16:59:50 -0800." <200101060059.QAA09816@pizda.ninka.net>
In message <200101060059.QAA09816@pizda.ninka.net> you write:
>
> You need to enable both CONNTRACK and full NAT in your configuration.
>
> Rusty, why doesn't the Config stuff just enforece this if it
> is necessary when enabling FTP support etc.?
Deja Vu: we've been through this before. But someone else
fuck^H^H^H^Hfixed the makefiles recently.
CONFIG_IP_NF_FTP controls BOTH the ftp connection tracking and NAT
code. The correct fix is below (untested, but you get the idea).
Matthew, does this fix it for you?
Rusty.
--
Hacking time.
diff -urN -I \$.*\$ -X /tmp/kerndiff.SnTZ7N --minimal linux-2.4.0-official/net/ipv4/netfilter/Config.in working-2.4.0/net/ipv4/netfilter/Config.in
--- linux-2.4.0-official/net/ipv4/netfilter/Config.in Tue Mar 28 04:35:56 2000
+++ working-2.4.0/net/ipv4/netfilter/Config.in Sat Jan 6 13:36:34 2001
@@ -42,6 +42,10 @@
define_bool CONFIG_IP_NF_NAT_NEEDED y
dep_tristate ' MASQUERADE target support' CONFIG_IP_NF_TARGET_MASQUERADE $CONFIG_IP_NF_NAT
dep_tristate ' REDIRECT target support' CONFIG_IP_NF_TARGET_REDIRECT $CONFIG_IP_NF_NAT
+ # If they want FTP, set same as $CONFIG_IP_NF_NAT (m or y).
+ if [ "$CONFIG_IP_NF_FTP" != "n" ]; then
+ define_tristate CONFIG_IP_NF_NAT_FTP $CONFIG_IP_NF_NAT
+ fi
fi
fi
diff -urN -I \$.*\$ -X /tmp/kerndiff.SnTZ7N --minimal linux-2.4.0-official/net/ipv4/netfilter/Makefile working-2.4.0/net/ipv4/netfilter/Makefile
--- linux-2.4.0-official/net/ipv4/netfilter/Makefile Sat Dec 30 09:07:24 2000
+++ working-2.4.0/net/ipv4/netfilter/Makefile Sat Jan 6 13:36:25 2001
@@ -35,7 +35,7 @@
obj-$(CONFIG_IP_NF_FTP) += ip_conntrack_ftp.o
# NAT helpers
-obj-$(CONFIG_IP_NF_FTP) += ip_nat_ftp.o
+obj-$(CONFIG_IP_NF_NAT_FTP) += ip_nat_ftp.o
# generic IP tables
obj-$(CONFIG_IP_NF_IPTABLES) += ip_tables.o
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-06 2:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-06 0:22 Matthew Schumacher
2001-01-06 0:59 ` David S. Miller
2001-01-06 2:40 ` Rusty Russell [this message]
2001-01-06 23:47 ` David S. Miller
2001-01-06 1:12 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E14EjHY-0005jK-00@halfway \
--to=rusty@linuxcare.com.au \
--cc=davem@redhat.com \
--cc=schu@schu.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®