From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: rasmus@jaquet.dk (Rasmus Andersen)
Cc: alan@lxorguk.ukuu.org.uk (Alan Cox),
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s/isa//g in drivers/scsi/g_NCR5380.c and some cleanup (242)
Date: Sun, 25 Feb 2001 14:34:28 +0000 (GMT) [thread overview]
Message-ID: <E14X2Fq-0003Ai-00@the-village.bc.nu> (raw)
In-Reply-To: <20010225151930.C764@jaquet.dk> from "Rasmus Andersen" at Feb 25, 2001 03:19:30 PM
> Looking at the define of NCR_5380_write
>
> #define NCR5380_write(reg, value) isa_writeb(NCR5380_map_name + +NCR53C400_mem_base + (reg), value)
>
> followed by an use of NCR5380_write
>
> NCR5380_write(C400_CONTROL_STATUS_REG, CSR_BASE | CSR_TRANS_DIR);
>
> I doubt that it is not the intention to write CSR_BASE | CSR_TRANS_DIR
> at the offset C400_CONTROL_STATUS_REG. But note that this argument
> swap only is in the code produced by -DCONFIG_SCSI_G_NCR5380_MEM.
> Perhaps you use CONFIG_SCSI_G_NCR5380_PORT? Otherwise I must admit
> that I have been had...
Im running PIO. However while I agree with that one Im dubious about the
inverts on the memcpy_*io bits
Alan
next prev parent reply other threads:[~2001-02-25 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-25 13:56 Rasmus Andersen
2001-02-25 14:05 ` Alan Cox
2001-02-25 14:19 ` Rasmus Andersen
2001-02-25 14:34 ` Alan Cox [this message]
2001-02-25 14:40 ` Rasmus Andersen
2001-02-25 14:46 ` Alan Cox
2001-02-25 14:54 ` Rasmus Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E14X2Fq-0003Ai-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®