From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: mark@cleggies.freeserve.co.uk (Mark Clegg)
Cc: rubini@vision.unipv.it, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.x kernel keyboard fix for Digital HiNote Ultra 2000
Date: Sun, 25 Feb 2001 17:57:50 +0000 (GMT) [thread overview]
Message-ID: <E14X5Qf-0003jD-00@the-village.bc.nu> (raw)
In-Reply-To: <3A98F047.733D7131@cleggies.freeserve.co.uk> from "Mark Clegg" at Feb 25, 2001 11:45:11 AM
> drivers/char/pc_keyb.c related to fixing problems on a Toshiba 4030cdt.
> It would appear that the fix for the Tosh, breaks the HiNote. (I don't
> have a Tosh to experiment with).
Reading the pc_keyb.c code two things strike me. The first is to wonder how
the hell Linus let that code get submitted ;) and the second is that the
delay rules are totally violated, and thats something we know the hinote's
hate.
> --- drivers/char/pc_keyb.c.orig Sat Feb 24 20:01:46 2001
> +++ drivers/char/pc_keyb.c Sat Feb 24 20:02:03 2001
> @@ -909,7 +909,7 @@
> aux_write_ack(AUX_ENABLE_DEV); /* Enable aux device */
> kbd_write_cmd(AUX_INTS_ON); /* Enable controller ints */
>
> - send_data(KBD_CMD_ENABLE); /* try to workaround
> toshiba4030cdt problem */
> +// send_data(KBD_CMD_ENABLE); /* try to workaround
> toshiba4030cdt problem */
Instead of commenting it put
mdelay(1);
before and after, and let me know if that helps
Alan
next prev parent reply other threads:[~2001-02-25 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-25 11:45 Mark Clegg
2001-02-25 17:57 ` Alan Cox [this message]
2001-02-26 20:44 ` Mark Clegg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E14X5Qf-0003jD-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@cleggies.freeserve.co.uk \
--cc=rubini@vision.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®