mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: gibbs@scsiguy.com (Justin T. Gibbs)
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix scsi_unblock_requests()
Date: Tue, 10 Apr 2001 17:06:26 +0100 (BST)	[thread overview]
Message-ID: <E14n0ey-0004W9-00@the-village.bc.nu> (raw)
In-Reply-To: <200104101502.f3AF2hs31410@aslan.scsiguy.com> from "Justin T. Gibbs" at Apr 10, 2001 09:02:43 AM

> In its current implementation, scsi_unblock_requests() simply
> clears host_self_blocked in the SCSI host struct.  This means
> that either a transaction must complete or a new transaction

Suppose the queue is unblocked from inside the functions called to process
the request. In that situation the old code is correct and your code might
introduce other problems

> unblocks.  scsi_queue_next_request() verifies all other state
> to ensure queuing new transactions is safe prior to proceeding.

Including recursion ?

The patch seems right apart from checking these details out further. 


  reply	other threads:[~2001-04-10 16:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-10 15:02 Justin T. Gibbs
2001-04-10 16:06 ` Alan Cox [this message]
2001-04-10 17:10   ` Justin T. Gibbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E14n0ey-0004W9-00@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=gibbs@scsiguy.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®