mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: torvalds@transmeta.com (Linus Torvalds)
Cc: alan@lxorguk.ukuu.org.uk (Alan Cox),
	bgerst@didntduck.org (Brian Gerst),
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86 page fault handler not interrupt safe
Date: Mon, 7 May 2001 22:37:10 +0100 (BST)	[thread overview]
Message-ID: <E14wsgr-00046Z-00@the-village.bc.nu> (raw)
In-Reply-To: <Pine.LNX.4.21.0105071003330.12733-100000@penguin.transmeta.com> from "Linus Torvalds" at May 07, 2001 10:12:58 AM

> If anybody has such a beast, please try this kernel patch _and_ running
> the F0 0F bug-producing program (search for it on the 'net - it must be

One apparent problem with this implementation

> +	 *
> +	 * This verifies that the fault happens in kernel space
> +	 * (error_code & 4) == 0, and that the fault was not a
> +	 * protection error (error_code & 1) == 0.
>  	 */
> -	if (address >= TASK_SIZE)
> +	if (address >= TASK_SIZE && !(error_code & 5))
>  		goto vmalloc_fault;

address might be from the following vmalloc fault. The error code would
indicate user space, so we would do a bogus user space fix up for vmalloc
space, fault and die.


  parent reply	other threads:[~2001-05-08  9:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-06  1:26 Brian Gerst
2001-05-07  0:53 ` Linus Torvalds
2001-05-07  3:54   ` Brian Gerst
2001-05-07 10:45   ` Alan Cox
2001-05-07 14:57     ` Brian Gerst
2001-05-07 15:07       ` Alan Cox
2001-05-07 17:12         ` Linus Torvalds
2001-05-07 17:27           ` David Woodhouse
2001-05-07 19:54           ` Brian Gerst
2001-05-07 20:16             ` Linus Torvalds
2001-05-07 21:37           ` Alan Cox [this message]
2001-05-07 22:52           ` Jesper Juhl
2001-05-07 18:35         ` Anton Altaparmakov
2001-05-07 16:51     ` Linus Torvalds
2001-05-07 17:32 Dunlap, Randy
2001-05-07 17:51 ` David Woodhouse
     [not found] <D5E932F578EBD111AC3F00A0C96B1E6F07DBE26F@orsmsx31.jf.intel .com>
2001-05-07 17:52 ` Anton Altaparmakov
     [not found] <3AF712D5.5D712E0F@didntduck.org>
2001-05-07 21:44 ` Linus Torvalds
2001-05-07 22:10   ` Brian Gerst
2001-05-08 10:45   ` Alan Cox
2001-05-08 16:45     ` Linus Torvalds
2001-05-09 22:12       ` Brian Gerst
2001-05-07 21:53 ` Nigel Gamble
2001-05-07 21:58 Anton Altaparmakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E14wsgr-00046Z-00@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=bgerst@didntduck.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®