From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: kash@stanford.edu (Kenneth Michael Ashcraft)
Cc: linux-kernel@vger.kernel.org, mc@cs.stanford.edu
Subject: Re: [CHECKER] 52 probable security holes in 2.4.6 and 2.4.6-ac2
Date: Sat, 14 Jul 2001 13:01:57 +0100 (BST) [thread overview]
Message-ID: <E15LO7S-00017P-00@the-village.bc.nu> (raw)
In-Reply-To: <Pine.GSO.4.31.0107131616290.8768-100000@myth9.Stanford.EDU> from "Kenneth Michael Ashcraft" at Jul 13, 2001 04:20:32 PM
> [BUG] Need a lower-bound check-- lo_encrypt_key_size is an int
> /home/kash/linux/2.4.6/drivers/block/loop.c:782:loop_set_status: ERROR:RANGE:757:782: Using user length "lo_encrypt_key_size" as argument to "memcpy" [type=LOCAL] [state = need_lb] set by 'copy_from_user':759 [linkages -> 759:info->lo_encrypt_key_size -> 757:info:start] [distance=110]
> if (lo->lo_encrypt_key_size && lo->lo_key_owner != current->uid &&
This one looks like a tool error
if ((unsigned int) info.lo_encrypt_key_size > LO_KEY_SIZE)
so the check is cast
In looking at the located ones I also found it missed a pile of related problems
it can check
There were a pile of
item *p=kmalloc(sizeof(item)*num_items);
if(p==NULL)
error
for(i=0;i<num_items;i++)
{
..
}
Where people rely on the kmalloc failing but forget that
large value * sizeof(item) -> small value after overflow
and the loop stomps all over kernel memory..
next prev parent reply other threads:[~2001-07-14 12:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-13 23:20 Kenneth Michael Ashcraft
2001-07-14 12:01 ` Alan Cox [this message]
2001-07-15 15:40 ` [PATCH] " Philipp Matthias Hahn
2001-07-16 15:56 ` Jeff Hartmann
2001-07-16 18:26 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E15LO7S-00017P-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=kash@stanford.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®