From: "Renaud Guérin" <rguerin@free.fr>
To: linux-kernel@vger.kernel.org
Subject: 2.4.8 breaks ATM
Date: Sun, 12 Aug 2001 14:43:47 +0200 [thread overview]
Message-ID: <E15Vuaq-0000BF-00@saturne.local> (raw)
The following part of the 2.4.8 patch seems to be a typo (">>" looks more
logical than ">" if vci_bit is a bitfield), and broke ATM for me:
--- v2.4.7/linux/net/atm/common.c Tue Jul 3 17:08:22 2001
+++ linux/net/atm/common.c Sun Aug 5 13:12:41 2001
@@ -210,7 +210,7 @@
if ((vpi != ATM_VPI_UNSPEC && vpi != ATM_VPI_ANY &&
vpi >> dev->ci_range.vpi_bits) || (vci != ATM_VCI_UNSPEC &&
- vci != ATM_VCI_ANY && vci >> dev->ci_range.vci_bits))
+ vci != ATM_VCI_ANY && vci > dev->ci_range.vci_bits))
return -EINVAL;
if (vci > 0 && vci < ATM_NOT_RSV_VCI &&
!capable(CAP_NET_BIND_SERVICE))
return -EPERM;
I simply reverted the patch and it works again.
--
-----------------------------------------------
Renaud Guerin
rguerin@free.fr - guerinre@utt.fr
Génie des Systèmes d'Information et de Décision
Université de Technologie de Troyes (France)
-----------------------------------------------
next reply other threads:[~2001-08-12 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-12 12:43 Renaud Guérin [this message]
2001-08-13 1:18 ` Mitchell Blank Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E15Vuaq-0000BF-00@saturne.local \
--to=rguerin@free.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®