From: Toby Milne <toby@svector.co.uk>
To: linux-kernel@vger.kernel.org
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: [PATCH] 2.4.10-ac9 CDRW Packet Fix
Date: Mon, 8 Oct 2001 20:35:13 +0100 [thread overview]
Message-ID: <E15qgFQ-0004pk-00@avalon.svector.gotadsl.co.uk> (raw)
The ac tree is missing some braces - without these the userspace buffer
contents never get copied into the kernel buffer.
--- linux/drivers/cdrom/cdrom.c Mon Oct 8 19:20:56 2001
+++ linux-2.4.10-ac9/drivers/cdrom/cdrom.c Mon Oct 8 19:19:04 2001
@@ -1983,10 +1983,10 @@
if (usense && !access_ok(VERIFY_WRITE, usense, sizeof(*usense)))
goto out;
- if (cgc->data_direction == CGC_DATA_READ)
+ if (cgc->data_direction == CGC_DATA_READ) {
if (!access_ok(VERIFY_READ, ubuf, cgc->buflen))
goto out;
- else if (cgc->data_direction == CGC_DATA_WRITE)
+ } else if (cgc->data_direction == CGC_DATA_WRITE)
if (copy_from_user(cgc->buffer, ubuf, cgc->buflen))
goto out;
next reply other threads:[~2001-10-08 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-08 19:35 Toby Milne [this message]
2001-10-10 6:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E15qgFQ-0004pk-00@avalon.svector.gotadsl.co.uk \
--to=toby@svector.co.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®