Re: 2.4.14 breaks block/loop.c (loopback device)

[Tim Tassonis <timtas@cubic.ch>]

Hi

> Hi!
>
> The latest kernel seems to breake the loop device. I used 2.4.13 before,
and
> everything was fine. I didn't change my kernel config when upgrading.
>
> I compile the loop device as a module. trying to modprobe/insmod it, I
get the
> following error message:
>
> unresolved symbol in loop.o: deactivate_page


You can apply below patch to fix this. Worked for me with no problem. This
was already discussed on the list and Linus said this would be the
appropriate fix.


diff -ru linux/drivers/block/loop.c linux-patched/drivers/block/loop.c
--- linux/drivers/block/loop.c  Tue Nov  6 10:41:15 2001
+++ linux-patched/drivers/block/loop.c  Tue Nov  6 10:43:51 2001
@@ -218,14 +218,12 @@
        index++;
        pos += size;
        UnlockPage(page);
-       deactivate_page(page);
        page_cache_release(page);
    }
    return 0;

 unlock:
    UnlockPage(page);
-   deactivate_page(page);
    page_cache_release(page);
 fail:
    return -1;