mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "RaúlNúñez de Arenas Coronado" <dervishd@jazzfree.com>
To: jgarzik@mandrakesoft.com, pgallen@randomlogic.com
Cc: kplug-list@kernel-panic.org, kplug-lpsg@kernel-panic.org,
	linux-kernel@vger.kernel.org
Subject: Re: Coding style - a non-issue
Date: Fri, 30 Nov 2001 20:53:38 +0100	[thread overview]
Message-ID: <E169tj8-00055G-00@DervishD.viadomus.com> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]

    Hi Jeff and Paul :)

>"Paul G. Allen" wrote:
>> IMEO, there is but one source as reference for coding style: A book by
>> the name of "Code Complete". (Sorry, I can't remember the author and I
>> no longer have a copy. Maybe my Brother will chime in here and fill in
>> the blanks since he still has his copy.)
>Hungarian notation???
>That was developed by programmers with apparently no skill to
>see/remember how a variable is defined.  IMHO in the Linux community
>it's widely considered one of the worst coding styles possible.

    Not at all... Hungarian notation is not so bad, except it is only
understood by people from hungary. So the name }:))) I just use it
when I write code for Hungary or secret code that no one should
read...

>>  - Short variable/function names that someone thinks is descriptive but
>> really isn't.
>not all variable names need their purpose obvious to complete newbies. 
>sometimes it takes time to understand the code's purpose, in which case
>the variable names become incredibly descriptive.

    Here you are right. The code can be seen really as a book: you
can start reading at the middle and yet understand some of the story,
but it's far better when you start at the beginning ;))) Moreover,
most of the variable and function names in the kernel code are quite
descriptive, IMHO.

    Of course, more comments and more descriptive names doesn't harm,
but some times they bloat the code...

    Raúl

             reply	other threads:[~2001-11-30 19:42 UTC|newest]

Thread overview: 184+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-30 19:53 RaúlNúñez de Arenas Coronado [this message]
2001-11-30 20:17 ` Paul G. Allen
2001-11-30 20:56   ` Tim Hockin
2001-12-03 18:34   ` Ragnar Hojland Espinosa
  -- strict thread matches above, loose matches on Subject: below --
2001-12-03 16:32 Dana Lacoste
2001-12-03 15:20 Tommy Reynolds
2001-12-02 20:53 n7ekg
2001-12-02 21:43 ` Brandon McCombs
2001-12-02 22:00   ` Alexander Viro
2001-12-02 22:05   ` Jonathan Abbey
2001-12-03  2:46 ` Trever L. Adams
2001-12-02  6:34 Khyron
2001-12-02 16:33 ` Alan Cox
2001-12-01 20:39 Stanislav Meduna
2001-12-01 21:18 ` Alan Cox
2001-12-01 22:44   ` Davide Libenzi
2001-12-02  8:01   ` Stanislav Meduna
2001-12-02 12:19     ` Rik van Riel
2001-12-02 16:31     ` Alan Cox
2001-12-02 16:36       ` Stanislav Meduna
2001-12-02 16:57         ` Alan Cox
2001-12-02 22:44           ` Chris Ricker
2001-12-03  6:43         ` David S. Miller
2001-12-03  2:44     ` Horst von Brand
2001-12-03  9:07       ` Stanislav Meduna
2001-12-04  1:21         ` Horst von Brand
2001-12-01 21:44 ` Mohammad A. Haque
2001-12-02  9:31 ` John Alvord
2001-12-01  7:03 Tim Hockin
2001-11-30 19:42 Galappatti, Kishantha
2001-11-30 18:19 Dana Lacoste
2001-11-30 18:36 ` Mohammad A. Haque
2001-11-28 23:29 Peter Waltenberg
2001-11-28 23:40 ` Russell King
2001-11-28 23:48 ` Alan Cox
2001-11-28 23:48 ` Robert Love
2001-11-29  0:17 ` Alexander Viro
2001-11-29  0:23   ` Larry McVoy
2001-11-29  0:57     ` Davide Libenzi
2001-11-30 10:00     ` Henning P. Schmiedehausen
2001-11-30 15:26       ` Larry McVoy
2001-11-30 16:39       ` Henning Schmiedehausen
2001-11-30 16:47         ` Jeff Garzik
2001-11-30 17:20           ` Martin Dalecki
2001-11-30 17:50             ` Russell King
2001-11-30 17:49               ` Martin Dalecki
2001-11-30 18:03                 ` Russell King
2001-11-30 18:31                   ` Martin Dalecki
2001-11-30 17:53             ` Alan Cox
2001-11-30 17:42               ` Martin Dalecki
2001-11-30 18:00                 ` Russell King
2001-11-30 17:55                   ` Martin Dalecki
2001-11-30 18:40                     ` Maciej W. Rozycki
2001-11-30 18:46                       ` Russell King
2001-11-30 17:54           ` antirez
2001-11-30 18:20             ` Paul G. Allen
2001-11-30 18:47               ` antirez
2001-11-30 20:20                 ` Paul G. Allen
2001-11-30 19:00               ` Jeff Garzik
2001-11-30 19:41                 ` John Kodis
2001-11-30 20:27                   ` Paul G. Allen
2001-12-01 21:52                     ` Kai Henningsen
2001-12-01 23:22                     ` john slee
2001-12-01 23:57                       ` Paul G. Allen
2001-11-30 17:15         ` Henning Schmiedehausen
2001-11-30 17:23           ` Martin Dalecki
2001-11-30 17:27           ` Larry McVoy
2001-11-30 17:49             ` Daniel Phillips
2001-11-30 18:07               ` Alexander Viro
2001-11-30 18:13               ` Larry McVoy
2001-11-30 18:43                 ` Daniel Phillips
2001-11-30 19:05                   ` Larry McVoy
2001-11-30 21:54                     ` Daniel Phillips
2001-11-30 22:06                       ` Larry McVoy
2001-11-30 22:17                         ` Andrew Morton
2001-11-30 22:51                           ` rddunlap
2001-12-01  0:35                           ` Rik van Riel
2001-12-01  0:44                             ` Daniel Phillips
2001-12-01  0:50                             ` Linus Torvalds
2001-12-01  1:09                               ` Mike Castle
2001-12-01  1:34                                 ` Davide Libenzi
2001-12-01 16:05                                 ` Jamie Lokier
2001-12-01 16:27                                   ` Rik van Riel
2001-12-01 18:54                                     ` Daniel Phillips
2001-12-01  1:15                               ` Petko Manolov
2001-12-01  2:02                               ` Tim Hockin
2001-12-01  2:57                                 ` Linus Torvalds
2001-12-01 23:11                                 ` Horst von Brand
2001-12-01  3:02                               ` Victor Yodaiken
2001-12-01  3:15                                 ` Linus Torvalds
2001-12-01  3:30                                   ` Larry McVoy
2001-12-01  3:34                                     ` Linus Torvalds
2001-12-01  4:10                                     ` Daniel Phillips
2001-12-01  4:44                                   ` Victor Yodaiken
2001-12-01  5:15                                     ` Linus Torvalds
2001-12-01  6:13                                       ` Daniel Phillips
2001-12-01 20:17                                         ` Victor Yodaiken
2001-12-01 20:30                                           ` Daniel Phillips
2001-12-01 12:34                                       ` Victor Yodaiken
2001-12-01 22:23                                       ` Kai Henningsen
2001-12-02  0:43                                       ` Davide Libenzi
2001-12-02  9:30                                         ` Lars Brinkhoff
2001-12-02 18:49                                       ` Ingo Molnar
2001-12-02 17:32                                         ` Rik van Riel
2001-12-02 20:12                                           ` Ingo Molnar
2001-12-02 18:41                                             ` Daniel Phillips
2001-12-02 19:04                                             ` Stephan von Krawczynski
2001-12-02 19:17                                               ` Daniel Phillips
2001-12-02 19:42                                               ` Stephan von Krawczynski
2001-12-04 10:50                                             ` Ingo Molnar
2001-12-05 22:18                                               ` Pavel Machek
2001-12-02 20:35                                           ` Ingo Molnar
2001-12-01  8:57                                     ` Alan Cox
2001-12-01 13:14                                       ` Victor Yodaiken
2001-12-01 13:38                                         ` Alan Cox
2001-12-01 15:15                                           ` Victor Yodaiken
2001-12-01 22:15                                   ` Kai Henningsen
2001-12-01  4:44                                 ` Andreas Dilger
2001-12-01  6:31                                 ` Stephen Satchell
2001-12-01  7:07                                   ` Zilvinas Valinskas
2001-12-01 23:18                                 ` Horst von Brand
2001-12-02 20:25                                   ` Larry McVoy
2001-12-02 23:51                                     ` Horst von Brand
2001-12-03  0:55                                     ` Daniel Phillips
2001-12-03 12:04                                       ` Victor Yodaiken
2001-12-03 13:20                                         ` Daniel Phillips
2001-12-07 18:15                                           ` Victor Yodaiken
2001-12-04 11:18                                       ` Ingo Molnar
2001-12-03  1:34                                     ` David L. Parsley
2001-12-03  3:06                                       ` Larry McVoy
2001-12-04  1:39                                         ` Horst von Brand
2001-12-04 22:25                                           ` Ragnar Hojland Espinosa
2001-12-04 18:38                                         ` Oliver Xymoron
2001-12-01  5:54                               ` Stephen Satchell
2001-12-01 11:18                               ` Rik van Riel
2001-12-01 18:05                                 ` Ingo Oeser
2001-12-01 18:21                                   ` Rik van Riel
2001-12-02 16:25                                 ` Martin Dalecki
2001-12-02 19:11                                   ` Ingo Molnar
2001-12-02 16:54                                 ` Stephan von Krawczynski
2001-12-01 22:20                               ` Horst von Brand
2001-12-02 17:18                               ` Rik van Riel
2001-11-30 22:31                         ` H. Peter Anvin
2001-11-30 18:44               ` Henning Schmiedehausen
2001-11-30 17:31           ` Alan Cox
2001-11-30 17:53           ` Henning Schmiedehausen
2001-11-30 18:07             ` Larry McVoy
2001-12-01  4:12               ` Mike Fedyk
2001-12-01  5:14                 ` Alexander Viro
2001-12-06  0:13                 ` Rusty Russell
2001-11-30 17:55           ` Alexander Viro
2001-11-30 18:07             ` Henning Schmiedehausen
2001-12-02 20:13               ` Pavel Machek
2001-12-02 21:28                 ` Alan Cox
2001-12-02 21:30                   ` Dave Jones
2001-12-01  0:12             ` Rik van Riel
2001-11-30 18:37           ` Jeff Garzik
2001-12-01  1:17           ` Keith Owens
2001-12-01  8:54             ` Gérard Roudier
2001-12-02 23:21           ` David S. Miller
2001-12-02 23:27             ` Keith Owens
2001-12-04 17:18               ` Gérard Roudier
2001-12-04 17:23                 ` Gérard Roudier
2001-12-04 22:28               ` David S. Miller
2001-12-02 20:03       ` Pavel Machek
2001-11-29  1:07   ` Petko Manolov
2001-11-29  1:56   ` Matthias Andree
2001-11-29  0:50 ` David S. Miller
2001-11-30 18:15 ` Paul G. Allen
2001-11-30 18:29   ` John H. Robinson, IV
2001-11-30 18:39     ` Paul G. Allen
2001-11-30 18:38   ` Nestor Florez
2001-11-30 18:56   ` Jeff Garzik
2001-11-30 20:06     ` Paul G. Allen
2001-11-30 20:18       ` Jeff Garzik
2001-12-01 17:53       ` David Weinehall
2001-12-01 21:29         ` Paul G. Allen
2001-12-02  2:03           ` Tracy R Reed
2001-12-05  3:42           ` Mike Fedyk
2001-11-30 20:41     ` H. Peter Anvin
2001-12-01 21:45       ` Kai Henningsen
2001-11-30 20:48     ` Andrew Morton
2001-11-30 23:17       ` Alexander Viro
2001-12-01  0:28       ` Rik van Riel
2001-12-01  0:22     ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E169tj8-00055G-00@DervishD.viadomus.com \
    --to=dervishd@jazzfree.com \
    --cc=jgarzik@mandrakesoft.com \
    --cc=kplug-list@kernel-panic.org \
    --cc=kplug-lpsg@kernel-panic.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pgallen@randomlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®