From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: zwane@linux.realnet.co.sz (Zwane Mwaikambo)
Cc: linux-kernel@vger.kernel.org (Linux Kernel)
Subject: Re: [PATCH] if (foo) kfree(foo) /fs cleanup
Date: Sat, 1 Dec 2001 12:45:26 +0000 (GMT) [thread overview]
Message-ID: <E16A9WI-00073W-00@the-village.bc.nu> (raw)
In-Reply-To: <Pine.LNX.4.33.0112011336040.11026-100000@netfinity.realnet.co.sz> from "Zwane Mwaikambo" at Dec 01, 2001 01:36:54 PM
IMHO this is precisely the wrong thing to do.
We should make the = NULL check within kfree do a BUG() call. That way we
fix the cases not being considered instead of hiding real bugs
next prev parent reply other threads:[~2001-12-01 12:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-01 11:36 Zwane Mwaikambo
2001-12-01 12:45 ` Alan Cox [this message]
2001-12-01 12:49 ` Jeff Garzik
2001-12-01 13:10 ` Zwane Mwaikambo
2001-12-01 16:33 ` [PATCH] if (foo) kfree(foo) /fs cleanup + reverted JBD code path changes Zwane Mwaikambo
2001-12-01 17:14 ` OGAWA Hirofumi
2001-12-01 17:48 ` Zwane Mwaikambo
2001-12-01 18:05 ` OGAWA Hirofumi
2001-12-01 18:13 ` Zwane Mwaikambo
[not found] ` <Pine.LNX.4.33.0112011830550.14290-100000@netfinity.realnet.co.s z>
2001-12-01 17:40 ` Alex Bligh - linux-kernel
2001-12-01 18:02 ` Zwane Mwaikambo
2001-12-01 18:11 ` Zwane Mwaikambo
2001-12-01 20:40 ` Raja R Harinath
2001-12-01 21:25 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E16A9WI-00073W-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linux.realnet.co.sz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®