mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@bonn-fries.net>
To: Andreas Dilger <adilger@turbolabs.com>, Andries.Brouwer@cwi.nl
Cc: acme@conectiva.com.br, ion@cs.columbia.edu,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Graichen <tgr@spoiled.org>
Subject: Re: [CFT] [JANITORIAL] Unbork fs.h
Date: Sat, 5 Jan 2002 00:33:45 +0100	[thread overview]
Message-ID: <E16MdqR-0001EQ-00@starship.berlin> (raw)
In-Reply-To: <UTC200201041516.PAA224847.aeb@cwi.nl> <20020104152056.Z12868@lynx.no>
In-Reply-To: <20020104152056.Z12868@lynx.no>

On January 4, 2002 11:20 pm, Andreas Dilger wrote:
> On Jan 04, 2002  15:16 +0000, Andries.Brouwer@cwi.nl wrote:
> >     sizeof (foo): 1611, sizeof(foo): 19364 => -bs should be removed
> >
> >     int
> >     foo(int x): 11408, int foo(int x): 57275 => -psl should be removed
> > 
> > I do not think good style is best defined by majority vote.
> 
> Certainly not.  However, the Lindent style I'm trying to achieve is that
> dictated by Linus.  However, CodingStyle doesn't give all of the details
> of how code should be formatted, so I have to look at the code to see
> what is actually there.
> 
> >     (void *) foo: 11274, (void *)foo: 17062 => -ncs should be added
> > 
> > Read old kernel sources.
> > 
> >         de = (struct minix_dir_entry *) (offset + bh->b_data);
> > 
> > 	:"S" ((long) name),"D" ((long) buffer),"c" (len)
> > 
> > 	if (32 != sizeof (struct minix_inode))
> 
> Well, that's what I was trying to do when I found out that lksr.org
> (hosted by innominate.de) was not available.  It seems the -ncs
> change is incorrect then (although my preference is to add it - there
> doesn't seem to me to be any benefit of having the extra space).

Thomas Graichen told me that lksr.org will be back up 'soon'.  Innominate.org 
is back up, run by Gerrit Pape, one of a group of Berliners who call 
themselves 'exnominate' (that would include me).  In fact, innominate itself 
is back, but that's a whole nuther story.

p.s., if Andries is right - and he probably is - then it looks like Linus's 
habitual style is 'space after cast' and 'space after sizeof'.  We could 
always ask.

If we put enough work into lindent, maybe we'll come up with a Linusbot?

--
Daniel

  reply	other threads:[~2002-01-04 23:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-04 15:16 Andries.Brouwer
2002-01-04 22:20 ` Andreas Dilger
2002-01-04 23:33   ` Daniel Phillips [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-01-05  1:07 Bryan Henderson
2002-01-04 16:45 Bryan Henderson
2002-01-04 22:15 ` Andreas Dilger
2002-01-03 12:47 Daniel Phillips
2002-01-03 14:03 ` Daniel Phillips
2002-01-03 15:45 ` Christoph Hellwig
2002-01-03 16:20   ` Daniel Phillips
2002-01-03 16:47     ` Alexander Viro
2002-01-03 17:25       ` Daniel Phillips
2002-01-03 18:25     ` Daniel Phillips
2002-01-03 18:35     ` Christoph Hellwig
2002-01-03 16:45   ` Alexander Viro
2002-01-03 18:04     ` Daniel Phillips
2002-01-03 16:05 ` Ion Badulescu
2002-01-03 16:34   ` Daniel Phillips
2002-01-03 16:28     ` Martin Dalecki
2002-01-03 16:45       ` Arnaldo Carvalho de Melo
2002-01-03 16:36     ` Arnaldo Carvalho de Melo
2002-01-03 17:05       ` Daniel Phillips
2002-01-03 17:07         ` Arnaldo Carvalho de Melo
2002-01-03 19:36           ` Andreas Dilger
2002-01-04  7:05             ` Daniel Phillips
2002-01-04  8:59               ` Andreas Dilger
2002-01-04 10:02                 ` Jeff Garzik
2002-01-03 23:25         ` J.A. Magallon
2002-01-04  1:44           ` Daniel Phillips
2002-01-04 14:52             ` J.A. Magallon
2002-01-03 18:53       ` Daniel Phillips
2002-01-03 20:31     ` Ion Badulescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E16MdqR-0001EQ-00@starship.berlin \
    --to=phillips@bonn-fries.net \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=acme@conectiva.com.br \
    --cc=adilger@turbolabs.com \
    --cc=ion@cs.columbia.edu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tgr@spoiled.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®