From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: adam@yggdrasil.com (Adam J. Richter)
Cc: linux-kernel@vger.kernel.org
Subject: Re: Patch: linux-2.5.2-pre6/drivers/message/i2o/i2o_block.c compilation fixes
Date: Sat, 5 Jan 2002 17:35:16 +0000 (GMT) [thread overview]
Message-ID: <E16Muiy-0000RJ-00@the-village.bc.nu> (raw)
In-Reply-To: <20020105014634.A22037@baldur.yggdrasil.com> from "Adam J. Richter" at Jan 05, 2002 01:46:34 AM
> The following patch fixes various compilation errors in
> linux-2.5.2-pre8/drivers/message/i2o/i2o_block.c, related to
> kdev_t and the new spinlock parameter to blk_init_queue.
> It might be a good idea for someone to look at the spinlocks
> that I created for blk_init_queue in this patch and tell me if
> I botched it.
Unless you have i2o hardware please leave that code alone. It just creates
more maintenance nightmares. I2O on 2.5.x is broken anyway and will oops
when loaded with or without you changes. I know about this. I will look at
it once the block layer changes are stable.
There are 32/64bit bugs, endian assumptions, and the complete absence of the
use of the PCI dma API to deal with too.
prev parent reply other threads:[~2002-01-05 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-05 9:46 Adam J. Richter
2002-01-05 17:35 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E16Muiy-0000RJ-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®