From: Daniel Phillips <phillips@bonn-fries.net>
To: Andrew Morton <akpm@zip.com.au>, Andrea Arcangeli <andrea@suse.de>
Cc: Alexander Viro <viro@math.psu.edu>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] truncate fixes
Date: Mon, 7 Jan 2002 13:41:28 +0100 [thread overview]
Message-ID: <E16NZ5v-0001Pv-00@starship.berlin> (raw)
In-Reply-To: <3C36DEA9.AEA2A402@zip.com.au> <20020107051259.L1561@athlon.random> <3C3923F5.485668AA@zip.com.au>
In-Reply-To: <3C3923F5.485668AA@zip.com.au>
On January 7, 2002 05:28 am, Andrew Morton wrote:
> Andrea Arcangeli wrote:
> >
> > > (I think I'll add a buffer_mapped() test to this code as well. It's
> > > a bit redundant because the fs shouldn't go setting BH_New and not
> > > BH_Mapped, but this code is _very_ rarely executed, and I haven't
> > > tested all filesystems...)
> >
> > correct, it shouldn't be necessary. I wouldn't add it. if a fs breaks the
> > buffer_new semantics it's the one that should be fixed methinks.
>
> You mean "don't be lazy. Audit all the filesystems"? Sigh. OK.
Isn't this a job for BUG?
--
Daniel
prev parent reply other threads:[~2002-01-07 12:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-05 11:08 Andrew Morton
2002-01-07 2:46 ` Andrea Arcangeli
2002-01-07 2:53 ` Andrew Morton
2002-01-07 3:16 ` Andrea Arcangeli
2002-01-07 5:24 ` Alexander Viro
2002-01-07 3:11 ` Andrew Morton
2002-01-07 3:58 ` Andrea Arcangeli
2002-01-07 3:32 ` Andrea Arcangeli
2002-01-07 3:48 ` Andrew Morton
2002-01-07 4:12 ` Andrea Arcangeli
2002-01-07 4:28 ` Andrew Morton
2002-01-07 5:09 ` Andrea Arcangeli
2002-01-07 12:41 ` Daniel Phillips [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E16NZ5v-0001Pv-00@starship.berlin \
--to=phillips@bonn-fries.net \
--cc=akpm@zip.com.au \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®