mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Manfred Spraul <manfred@colorfullife.com>,
	mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: cross-cpu balancing with the new scheduler
Date: Mon, 14 Jan 2002 15:37:27 +1100	[thread overview]
Message-ID: <E16PysB-0006zU-00@wagner.rustcorp.com.au> (raw)
In-Reply-To: Your message of "Sun, 13 Jan 2002 18:49:16 -0800." <Pine.LNX.4.40.0201131842570.937-100000@blue1.dev.mcafeelabs.com>

In message <Pine.LNX.4.40.0201131842570.937-100000@blue1.dev.mcafeelabs.com> yo
u write:
> On Mon, 14 Jan 2002, Rusty Russell wrote:
> 
> > This could be fixed by making "nr_running" closer to a "priority sum".
> 
> I've a very simple phrase when QA is bugging me with these corner cases :
> 
> "As Designed"

My point is: it's just a heuristic number.  It currently reflects the
number on the runqueue, but there's no reason it *has to* (except the
name, of course).

1) The nr_running() function can use rq->active->nr_active +
   rq->expired->nr_active.  And anyway it's only as "am I
   idle?".

2) The test inside schedule() can be replaced by checking the result
   of the sched_find_first_zero_bit() (I have a patch which does this
   to good effect, but for other reasons).

The other uses of nr_running are all "how long is this runqueue for
rebalancing", and Ingo *already* modifies his use of this number,
using the "prev_nr_running" hack.

Hope that clarifies,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

  reply	other threads:[~2002-01-14  4:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-13 17:01 Manfred Spraul
2002-01-14  2:19 ` Rusty Russell
2002-01-14  2:49   ` Davide Libenzi
2002-01-14  4:37     ` Rusty Russell [this message]
2002-01-14 15:39     ` Manfred Spraul
2002-01-14 15:50       ` Davide Libenzi
2002-01-14 17:44       ` Ingo Molnar
2002-01-14  6:10 ` Anton Blanchard
2002-01-15 16:37   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E16PysB-0006zU-00@wagner.rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=davidel@xmailserver.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®