mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: davem@redhat.com (David S. Miller)
Cc: alan@lxorguk.ukuu.org.uk, davej@suse.de,
	eike@bilbo.math.uni-mannheim.de, linux-kernel@vger.kernel.org
Subject: Re: [2.5.4-pre3] link error in drivers/video/video.o
Date: Fri, 8 Feb 2002 16:26:06 +0000 (GMT)	[thread overview]
Message-ID: <E16ZDqh-0004AV-00@the-village.bc.nu> (raw)
In-Reply-To: <20020208.074857.88474129.davem@redhat.com> from "David S. Miller" at Feb 08, 2002 07:48:57 AM

>    That is incorrect. The warning occurs because someone made bogus changes to
>    the vesa driver without understanding what was going on. The vesa frame
>    buffer returned by the BIOS is a physical cpu address not a bus address
>    and nothing to do with magic PCI mappings.
> 
> There were no changes made, in fact the VESA driver by your own
> definition was buggy before my changes went in. :-) It was using
> bus_to_virt and virt_to_bus all along Alan.

My error then. That or someone broke it around 2.0 8). It should be using
phys_to_virt. Its the usual weirdness of talking to the BIOS which talks in
CPU physical addresses.

VESAfb also genuinely does not know how the frame buffer is wired into the
system, it just has a physical address. Another approach I guess might be
to check if the address range if in a PCI root bridge window and if so 
ioremap it. That possibly also means someone should get around to shrinking
the 1Gb (actually 900M) kernel to 768Mb because some frame buffers are now
at 128Mb of ram

  reply	other threads:[~2002-02-08 16:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-08 14:22 Rolf Eike Beer
2002-02-08 14:57 ` Dave Jones
2002-02-08 15:48   ` David S. Miller
2002-02-08 16:26     ` Alan Cox [this message]
2002-02-09 23:05       ` Pavel Machek
2002-02-08 15:55   ` Alan Cox
2002-02-08 15:01 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E16ZDqh-0004AV-00@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=davej@suse.de \
    --cc=davem@redhat.com \
    --cc=eike@bilbo.math.uni-mannheim.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®