From: Daniel Phillips <phillips@bonn-fries.net>
To: Bill Davidsen <davidsen@tmr.com>, Andrew Morton <akpm@zip.com.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] sys_sync livelock fix
Date: Wed, 13 Feb 2002 16:29:21 +0100 [thread overview]
Message-ID: <E16b1LV-0001ol-00@starship.berlin> (raw)
In-Reply-To: <Pine.LNX.3.96.1020213000859.8487A-100000@gatekeeper.tmr.com>
In-Reply-To: <Pine.LNX.3.96.1020213000859.8487A-100000@gatekeeper.tmr.com>
On February 13, 2002 06:21 am, Bill Davidsen wrote:
> On Tue, 12 Feb 2002, Andrew Morton wrote:
>
> > IMO, the SuS definition sucks. We really do want to do our best to
> > ensure that pending writes are committed to disk before sys_sync()
> > returns. As long as that doesn't involve waiting until mid-August.
>
> The current behaviour allows the system to hang forever waiting for
> sync(2). In practice it does actually wait minutes on a busy system (df
> has --no-sync for that reason) when there is no reason for that to happen.
> I think that not only sucks worse, it's non-standard as well.
Nothing sucks worse than losing your data. Let's concentrate on fixing
shutdown, not breaking (linux) sync.
> > For example, ext3 users get to enjoy rebooting with `sync ; reboot -f'
> > to get around all those silly shutdown scripts. This very much relies
> > upon the sync waiting upon the I/O.
>
> Because people count on something broken we should keep the bug? You do
> realize that the sync may NEVER finish?
You do realize that if you lose your data you may NEVER get it back? ;-)
> That's not in theory, I have news
> servers which may wait overnight without finishing a "df" iwthout the
> option.
OK, what you're really saying is, we need a way to kill the sync process
if it runs overtime, no?
> > I mean, according to SUS, our sys_sync() implementation could be
> >
> > asmlinkage void sys_sync(void)
> > {
> > return;
> > }
> >
> > Because all I/O is already scheduled, thanks to kupdate.
>
> I think the wording is queued, and I would read that as "on the
> elevator."
Well now you're adding your own semantics to SuS, welcome to the party.
I vote we keep the existing and-don't-come-back-until-you're-done Linux
semantics.
> Your example is a good example of bad practive, since even with
> ext3 a program creating files quickly would lose data, even though the
> directory structure is returned to a known state, without stopping the
> writing processes the results are unknown.
Huh? You know about journal commit, right?
--
Daniel
next prev parent reply other threads:[~2002-02-13 15:25 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-12 23:13 Andrew Morton
2002-02-12 23:31 ` Alan Cox
2002-02-12 23:22 ` Andrew Morton
2002-02-13 0:28 ` Alan Cox
2002-02-13 3:28 ` Bill Davidsen
2002-02-13 3:46 ` Jeff Garzik
2002-02-13 15:11 ` Daniel Phillips
2002-02-13 22:24 ` Bill Davidsen
2002-02-13 22:41 ` Mike Fedyk
2002-02-14 0:26 ` Daniel Phillips
2002-02-14 0:37 ` Andrew Morton
2002-02-14 0:49 ` Daniel Phillips
2002-02-14 0:53 ` Andrew Morton
2002-02-14 1:27 ` Daniel Phillips
2002-02-14 1:29 ` Andrew Morton
2002-02-14 1:59 ` Mike Fedyk
2002-02-14 2:07 ` Daniel Phillips
2002-02-13 23:31 ` Rob Landley
2002-02-14 0:44 ` Daniel Phillips
2002-02-12 23:29 ` Rik van Riel
2002-02-13 0:25 ` Alan Cox
2002-02-13 0:15 ` Rik van Riel
2002-02-13 0:36 ` Alan Cox
2002-02-13 0:36 ` Rik van Riel
2002-02-13 0:39 ` Andrew Morton
2002-02-13 3:42 ` Bill Davidsen
2002-02-13 3:54 ` Bill Davidsen
2002-02-13 4:01 ` Jeff Garzik
2002-02-13 4:53 ` Bill Davidsen
2002-02-13 15:17 ` Daniel Phillips
2002-02-13 4:29 ` Andrew Morton
2002-02-13 5:21 ` Bill Davidsen
2002-02-13 5:35 ` Andrew Morton
2002-02-18 2:29 ` Bill Davidsen
2002-02-13 14:09 ` bill davidsen
2002-02-13 15:29 ` Daniel Phillips [this message]
2002-02-13 22:53 ` Bill Davidsen
2002-02-14 0:33 ` Daniel Phillips
2002-02-13 1:36 ` What is a livelock? (was: [patch] sys_sync livelock fix) Olaf Dietsche
2002-02-13 1:56 ` Andrew Morton
2002-02-13 2:30 ` Olaf Dietsche
2002-02-13 2:39 ` Andrew Morton
2002-02-13 16:19 ` Olaf Dietsche
2002-02-13 2:52 ` William Lee Irwin III
2002-02-18 22:19 ` David Schwartz
2002-02-13 2:33 ` Rob Landley
2002-02-13 9:18 [patch] sys_sync livelock fix Andries.Brouwer
2002-02-14 0:57 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E16b1LV-0001ol-00@starship.berlin \
--to=phillips@bonn-fries.net \
--cc=akpm@zip.com.au \
--cc=davidsen@tmr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®