From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] TRIVIAL 2.5.12 declance patch
Date: Wed, 01 May 2002 17:17:57 +1000 [thread overview]
Message-ID: <E172oNB-0007oN-00@wagner.rustcorp.com.au> (raw)
"Maciej W. Rozycki" <macro@ds2.pg.gda.pl>: [patch] 2.4.19-pre7: A few declance multicast updates:
Hello,
It seems all Ethernet device drivers were bulk-converted to use the new
common CRC functions. I discovered declance used incorrect endianness to
calculate the sum for its multicast filter and had a few alignment
problems there. I fixed these bugs in the MIPS/Linux CVS tree which is at
2.4.18 now. Here is the respective update for the official kernel.
The bugs make the filter non-functional. Please apply.
Maciej
--- trivial-2.5.12/drivers/net/declance.c.orig Wed May 1 17:15:09 2002
+++ trivial-2.5.12/drivers/net/declance.c Wed May 1 17:15:09 2002
@@ -791,6 +791,8 @@
ib->mode = 0;
ib->filter [0] = 0;
ib->filter [2] = 0;
+ ib->filter [4] = 0;
+ ib->filter [6] = 0;
lance_init_ring(dev);
load_csrs(lp);
@@ -943,9 +945,9 @@
if (!(*addrs & 1))
continue;
- crc = ether_crc(6, addrs);
+ crc = ether_crc_le(6, addrs);
crc = crc >> 26;
- mcast_table[crc >> 3] |= 1 << (crc & 0xf);
+ mcast_table[2 * (crc >> 4)] |= 1 << (crc & 0xf);
}
return;
}
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
reply other threads:[~2002-05-01 7:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E172oNB-0007oN-00@wagner.rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®