From: Paul Menage <pmenage@ensim.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org
Cc: pmenage@ensim.com
Subject: Re: [PATCH] Replace exec_permission_lite() with inlined vfs_permission()
Date: Thu, 02 May 2002 19:36:23 -0700 [thread overview]
Message-ID: <E173Svn-0004LE-00@pmenage-dt.ensim.com> (raw)
In-Reply-To: Your message of "Thu, 02 May 2002 22:16:37 EDT." <Pine.GSO.4.21.0205022159040.17171-100000@weyl.math.psu.edu>
>
>IMO it's a bad idea. In many cases we have ->permission() but it's
>perfectly OK with being called under dcache_lock - either always or
>in (fs-specific) "fast case".
>
>I would prefer ->permission_light() that would always be called
>under dcache_lock and besides the usual values could return -EAGAIN.
>In that case ->permission() would be called in a normal way.
>
OK - a few details/matters of taste:
- how about similar dcache_lock-safe versions of d_op->revalidate()
and i_op->follow_link()?
- an alternative to separate methods is to add a "noblock" argument
to the existing methods. This entails more breakage in the short term.
- permission_light() or permission_lite()? :-)
Paul
next prev parent reply other threads:[~2002-05-03 2:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-03 1:44 Paul Menage
2002-05-03 2:16 ` Alexander Viro
2002-05-03 2:36 ` Paul Menage [this message]
2002-05-03 9:03 ` Paul Menage
2002-05-03 9:09 ` Alexander Viro
2002-05-03 17:23 ` Paul Menage
2002-05-03 18:14 ` Trond Myklebust
2002-05-03 9:10 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E173Svn-0004LE-00@pmenage-dt.ensim.com \
--to=pmenage@ensim.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®