From: Rusty Russell <rusty@rustcorp.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix BUG macro
Date: Fri, 17 May 2002 10:31:41 +1000 [thread overview]
Message-ID: <E178Ven-0007jA-00@wagner.rustcorp.com.au> (raw)
In-Reply-To: Your message of "Thu, 16 May 2002 12:21:44 +0100." <Pine.LNX.4.21.0205161154410.1036-100000@localhost.localdomain>
In message <Pine.LNX.4.21.0205161154410.1036-100000@localhost.localdomain> you
write:
> On Thu, 16 May 2002, Rusty Russell wrote:
>
> > Replaces filename with object name. Sure, it's not as canonical, but
> > it means that ccache works across different directories (at the
> > moment, ccache gets almost no caceh hits when you compile in a
> > different dir).
>
> __STRINGIZE(KBUILD_BASENAME) sounds good, except in inline
> function from header file; perhaps that's why you're adding
> __FUNCTION__, which will waste a lot of space.
Um, show me where sizeof(KBUILD_BASENAME) + sizeof(__FUNCTION__) >
sizeof(__FILENAME__).
> Suggest you
> should test __INCLUDE_LEVEL__: use __STRINGIZE(KBUILD_BASENAME)
> at __INCLUDE_LEVEL__ 0, __FUNCTION__ at included levels?
That'd be cute. Of course best would be using KBUILD_BASENAME (which
means BUG() in a header works correclty) and make BUG() take a string
arg.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-05-17 0:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-16 8:08 Rusty Russell
2002-05-16 11:21 ` Hugh Dickins
2002-05-17 0:31 ` Rusty Russell [this message]
2002-05-17 7:56 ` Hugh Dickins
2002-05-17 9:43 ` Rusty Russell
2002-05-17 11:47 ` Hugh Dickins
2002-05-17 12:02 ` Andreas Schwab
2002-05-17 12:46 ` Rusty Russell
2002-05-17 13:19 ` Hugh Dickins
2002-05-16 16:27 ` Ghozlane Toumi
2002-05-17 2:25 ` Rusty Russell
2002-05-17 2:41 ` Andrew Morton
2002-05-17 4:25 ` Rusty Russell
2002-05-17 4:50 ` Andrew Morton
2002-05-17 5:20 ` Rusty Russell
2002-05-17 6:44 ` Andrew Morton
2002-05-17 9:39 ` Rusty Russell
2002-05-17 16:14 ` Kai Germaschewski
2002-05-17 18:41 ` Andrew Morton
2002-05-17 22:35 ` Stevie O
2002-05-17 23:09 ` Kai Germaschewski
2002-05-18 6:28 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E178Ven-0007jA-00@wagner.rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®