From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: hugh@veritas.com (Hugh Dickins)
Cc: alan@lxorguk.ukuu.org.uk (Alan Cox),
rui.sousa@laposte.net (Rui Sousa),
rusty@rustcorp.com.au (Rusty Russell),
linux-kernel@vger.kernel.org,
kernel-janitor-discuss@lists.sourceforge.net
Subject: Re: AUDIT of 2.5.15 copy_to/from_user
Date: Sun, 19 May 2002 18:36:06 +0100 (BST) [thread overview]
Message-ID: <E179UbG-000473-00@the-village.bc.nu> (raw)
In-Reply-To: <Pine.LNX.4.21.0205191755200.9972-100000@localhost.localdomain> from "Hugh Dickins" at May 19, 2002 06:01:31 PM
> On Sun, 19 May 2002, Alan Cox wrote:
> > >
> > > On the emu10k1 driver we use access_ok(VERIFY_READ) once at the beginning
> > > of the write() routine to check we can access the user buffer. After that
> > > we always use __copy_from_user() and we trust it not to fail. Is this
> > > correct, or not?
> >
> > This is correct
>
> Am I right to read that as "This is a correct description of what is
> currently done in the emu10k1 driver, but what it is doing is incorrect"?
It seems correct in what it is doing, to a point. copy_from_user won't ever
fail in a fatal manner. It may not copy enough data and zero fill returning
an error code. Reporting of that error isnt required however, its just
good manners
next prev parent reply other threads:[~2002-05-19 17:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-19 4:18 Rusty Russell
2002-05-18 22:55 ` Arnaldo Carvalho de Melo
2002-05-18 23:12 ` [BKPATCH] " Arnaldo Carvalho de Melo
2002-05-18 23:54 ` Arnaldo Carvalho de Melo
2002-05-19 0:14 ` [BKPATCH] OSS: " Arnaldo Carvalho de Melo
2002-05-19 0:19 ` Arnaldo Carvalho de Melo
2002-05-19 1:16 ` Arnaldo Carvalho de Melo
2002-05-19 1:38 ` [BKPATCH] USB: " Arnaldo Carvalho de Melo
2002-05-20 6:07 ` Greg KH
2002-05-19 6:30 ` Kai Germaschewski
2002-05-19 0:45 ` Arnaldo Carvalho de Melo
2002-05-19 1:07 ` [BKPATCH] ISDN: " Arnaldo Carvalho de Melo
2002-05-19 11:44 ` Alan Cox
2002-05-19 12:10 ` Stephen Rothwell
2002-05-19 12:15 ` Rui Sousa
2002-05-19 12:46 ` Alan Cox
2002-05-19 12:58 ` Rui Sousa
2002-05-19 13:43 ` Alan Cox
2002-05-19 17:01 ` Hugh Dickins
2002-05-19 17:36 ` Alan Cox [this message]
2002-05-19 17:52 ` David Woodhouse
2002-05-19 18:20 ` Alan Cox
2002-05-19 18:02 ` David Woodhouse
2002-05-19 22:54 ` Alan Cox
2002-05-20 1:38 ` Rusty Russell
2002-05-20 11:47 ` Alan Cox
2002-05-19 12:13 ` Alan Cox
2002-06-07 8:54 ` David S. Miller
2002-05-19 12:48 ` Arnaldo Carvalho de Melo
2002-05-19 17:28 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E179UbG-000473-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=hugh@veritas.com \
--cc=kernel-janitor-discuss@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.sousa@laposte.net \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®