From: Daniel Phillips <phillips@bonn-fries.net>
To: Tim Schmielau <tim@physik3.uni-rostock.de>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [rfc,patch] breaking up sched.h
Date: Sun, 26 May 2002 00:57:34 +0200 [thread overview]
Message-ID: <E17BkTf-0003p3-00@starship> (raw)
In-Reply-To: <Pine.LNX.4.33.0205242219001.30843-100000@gans.physik3.uni-rostock.de>
On Friday 24 May 2002 22:34, Tim Schmielau wrote:
> While it's quite common to do "current->foo", every file doing
> so needs to #include <linux/sched.h> for the declaration of
> task_struct.
> In order to reduce the number of #include <linux/sched.h>, I'd propose to
> move task_struct to a separate header file (patch below), and include it
> from <asm/current.h>.
Such separation of data vs function declarations is a good thing. This
results in a source tree which is easier to work with and contains fewer
strange hacks to get around include order problems. Possibly, the kernel
may end up compiling faster as well, if some of the includes aimed merely
at obtaining the data definitions don't have to pick up the (much
bulkier) operation definitions as well.
This is the same technique I used in my 'early_page' patch set, which
gave me the ability to rewrite all the address operations in the page.h
and pgtable.h headers as inline functions instead of macros.
--
Daniel
prev parent reply other threads:[~2002-05-25 22:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-24 20:34 Tim Schmielau
2002-05-24 20:52 ` Russell King
2002-05-24 21:07 ` Tim Schmielau
2002-05-25 22:57 ` Daniel Phillips [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17BkTf-0003p3-00@starship \
--to=phillips@bonn-fries.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@physik3.uni-rostock.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®