From: Daniel Phillips <phillips@arcor.de>
To: Jesse Barnes <jbarnes@sgi.com>, martin@dalecki.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lock assertion macros for 2.5.28
Date: Sat, 27 Jul 2002 15:59:00 +0200 [thread overview]
Message-ID: <E17YS61-0005Ke-00@starship> (raw)
In-Reply-To: <20020726174039.GB793866@sgi.com>
On Friday 26 July 2002 19:40, Jesse Barnes wrote:
> On Fri, Jul 26, 2002 at 07:11:28AM +0200, Marcin Dalecki wrote:
> > Well one one place? Every single implementation of the request_fn
> > method from the request_queue_t needs to hold some
> > lock associated with the queue in question.
> >
> > In fact you will find ASSERT_LOCK macros sparnkled through the scsi code
> > already right now. BTW> ASSERT_HOLDS would sound a bit more
> > familiar to some of us.
> >
> > This minor issue asside I think that your idea is a good thing.
>
> Thanks for the pointer. I'll change those assertions over in the
> next revision.
The scsi version is not the same, it's going to need to be changed to
this sensible version.
The original name is better and shorter. I doubt there is anybody who
will not know immediately what MUST_HOLD(&lock) means.
--
Daniel
next prev parent reply other threads:[~2002-07-27 13:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-25 23:30 Jesse Barnes
2002-07-26 5:11 ` Marcin Dalecki
2002-07-26 17:40 ` Jesse Barnes
2002-07-27 13:59 ` Daniel Phillips [this message]
2002-07-26 12:09 ` Joshua MacDonald
2002-07-26 17:42 ` Jesse Barnes
2002-07-26 17:54 ` Christoph Hellwig
2002-07-26 18:05 ` Jesse Barnes
2002-07-27 13:56 ` Daniel Phillips
2002-07-26 19:38 ` Robert Love
2002-08-02 15:17 ` Joshua MacDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17YS61-0005Ke-00@starship \
--to=phillips@arcor.de \
--cc=jbarnes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@dalecki.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®