From: Marek Michalkiewicz <marekm@amelek.gda.pl>
To: Tim Waugh <twaugh@redhat.com>
Cc: Marek Michalkiewicz <marekm@amelek.gda.pl>,
serial24@macrolink.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] fix parport_serial / serial link order (for 2.4.20-pre8)
Date: Mon, 30 Sep 2002 12:07:51 +0200 (CEST) [thread overview]
Message-ID: <E17vxSx-0004cg-00@alf.amelek.gda.pl> (raw)
In-Reply-To: <20020930094012.GC20605@redhat.com>
> What was wrong with the original, much smaller patch that you sent me
> previously (below)?
It was a hack (more a proof of concept where the problem was), and
Pavel Janik had some trouble with it (it hung before detecting the PCI
serial ports, while changing the link order worked fine - not sure why,
could this be a kernel stack overflow resulting from calling rs_init()
from within parport code instead of directly from the top level?).
My most recent patch simply moves parport_serial.c to a different
directory - that's why the patch is so big, but it doesn't otherwise
change a single line in that moved file (I split NetMos support to
the next patch, after this one is accepted and possible NetMos bugs
are resolved - works fine here with parport in polling mode, IRQ
sharing with serial ports not tested).
After the parport_serial.c move, the init order would be:
- parport
- serial
- parport_serial (needs both of the above initialized first)
- other char/block/net drivers (some of them might need the parallel
ports, including the PCI ones: lp, paride, plip - so moving all of
parport after char/block/net would be wrong)
> I'm happy to accept whichever patch is the better.
I'd suggest the more recent (larger, but not really...) one.
Thanks,
Marek
prev parent reply other threads:[~2002-09-30 10:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-26 20:05 Marek Michalkiewicz
2002-09-27 1:18 ` Zwane Mwaikambo
2002-09-27 6:35 ` Marek Michalkiewicz
2002-09-28 4:24 ` Zwane Mwaikambo
2002-09-29 18:00 ` Marek Michalkiewicz
2002-09-29 19:14 ` Zwane Mwaikambo
2002-09-29 20:24 ` Marek Michalkiewicz
2002-09-30 9:20 ` Zwane Mwaikambo
2002-09-30 10:27 ` Marek Michalkiewicz
2002-09-30 9:40 ` Tim Waugh
2002-09-30 9:49 ` Russell King
2002-09-30 10:07 ` Marek Michalkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17vxSx-0004cg-00@alf.amelek.gda.pl \
--to=marekm@amelek.gda.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=serial24@macrolink.com \
--cc=twaugh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®