From: "Samium Gromoff" <_deepfire@mail.ru>
To: greg@kroah.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.4, 2.5, USB] locking issue
Date: Mon, 18 Nov 2002 17:34:20 +0300 [thread overview]
Message-ID: <E18Dmyi-000FRS-00@f16.mail.ru> (raw)
The possible problem is encountered in ehci-q.c and ehci-sched.c
in 2.4.19-pre9 and in one occurence in ehci-q.c of 2.5.47.
the offending pattern is the same in both files:
if (!list_empty (qtd_list)) {
-----------------------8<----------------------------------------------
list_splice (qtd_list, &qh->qtd_list);
qh_update (qh, list_entry (qtd_list->next, struct ehci_qtd, qtd\_list));
-----------------------8<----------------------------------------------
} else {
qh->hw_qtd_next = qh->hw_alt_next = EHCI_LIST_END;
}
since list_splice() the qtd_list is diposed of its belongings and
immediately in the next line we rely on qtd_list->next to point
at an existing list_head.
i haven`t noticed any locking out there, and i`m afraid of what
could result from a preemption happening between these two lines.
regards, Samium Gromoff
_______________________________
____________________________________
next reply other threads:[~2002-11-18 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-18 14:34 Samium Gromoff [this message]
2002-11-20 8:45 ` Greg KH
2002-11-20 15:40 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E18Dmyi-000FRS-00@f16.mail.ru \
--to=_deepfire@mail.ru \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®