From: Christian Borntraeger <linux@borntraeger.net>
To: <kai.germaschewski@gmx.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] isdn-tty driver not HZ aware
Date: Mon, 2 Dec 2002 18:45:46 GMT [thread overview]
Message-ID: <E18IvZl-0000Lm-00@mrelayng.kundenserver.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]
This patch makes isdn_tty HZ aware.
The first change changes 3000 jiffies (now 3 seconds) to 30 seconds according to the comment.
I dont know, if the second change (schedule_timeout(50);) has to be half a second but this was the value used in 2.4.
--- drivers/isdn/i4l/isdn_tty.c.org 2002-11-27 22:36:16.000000000 +0000
+++ drivers/isdn/i4l/isdn_tty.c 2002-12-01 19:03:15.000000000 +0000
@@ -1876,7 +1876,7 @@
* line status register.
*/
if (info->flags & ISDN_ASYNC_INITIALIZED) {
- tty_wait_until_sent(tty, 3000); /* 30 seconds timeout */
+ tty_wait_until_sent(tty, 30 * HZ); /* 30 seconds timeout */
/*
* Before we drop DTR, make sure the UART transmitter
* has completely drained; this is especially
@@ -1901,7 +1901,7 @@
tty->closing = 0;
if (info->blocked_open) {
set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(50);
+ schedule_timeout(HZ/2);
wake_up_interruptible(&info->open_wait);
}
info->flags &= ~(ISDN_ASYNC_NORMAL_ACTIVE | ISDN_ASYNC_CALLOUT_ACTIVE |
[-- Attachment #2: isdn.patch --]
[-- Type: application/octet-stream, Size: 762 bytes --]
--- drivers/isdn/i4l/isdn_tty.c.org 2002-11-27 22:36:16.000000000 +0000
+++ drivers/isdn/i4l/isdn_tty.c 2002-12-01 19:03:15.000000000 +0000
@@ -1876,7 +1876,7 @@
* line status register.
*/
if (info->flags & ISDN_ASYNC_INITIALIZED) {
- tty_wait_until_sent(tty, 3000); /* 30 seconds timeout */
+ tty_wait_until_sent(tty, 30 * HZ); /* 30 seconds timeout */
/*
* Before we drop DTR, make sure the UART transmitter
* has completely drained; this is especially
@@ -1901,7 +1901,7 @@
tty->closing = 0;
if (info->blocked_open) {
set_current_state(TASK_INTERRUPTIBLE);
- schedule_timeout(50);
+ schedule_timeout(HZ/2);
wake_up_interruptible(&info->open_wait);
}
info->flags &= ~(ISDN_ASYNC_NORMAL_ACTIVE | ISDN_ASYNC_CALLOUT_ACTIVE |
reply other threads:[~2002-12-02 18:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E18IvZl-0000Lm-00@mrelayng.kundenserver.de \
--to=linux@borntraeger.net \
--cc=kai.germaschewski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®