From: davej@redhat.com
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org, akpm@osdl.org, benh@kernel.crashing.org
Subject: logic error in radeonfb.
Date: Fri, 23 Jan 2004 06:35:25 +0000 [thread overview]
Message-ID: <E1Ajuub-0000xr-00@hardwired> (raw)
Looks like another instance of a ! in the wrong place.
Dave
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/video/radeonfb.c linux-2.5/drivers/video/radeonfb.c
--- bk-linus/drivers/video/radeonfb.c 2004-01-21 15:58:42.000000000 +0000
+++ linux-2.5/drivers/video/radeonfb.c 2004-01-21 17:48:54.000000000 +0000
@@ -2319,7 +2319,7 @@ static int radeon_set_backlight_enable(i
lvds_gen_cntl |= (LVDS_BL_MOD_EN | LVDS_BLON);
if (on && (level > BACKLIGHT_OFF)) {
lvds_gen_cntl |= LVDS_DIGON;
- if (!lvds_gen_cntl & LVDS_ON) {
+ if (!(lvds_gen_cntl & LVDS_ON)) {
lvds_gen_cntl &= ~LVDS_BLON;
OUTREG(LVDS_GEN_CNTL, lvds_gen_cntl);
(void)INREG(LVDS_GEN_CNTL);
next reply other threads:[~2004-01-23 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 6:35 davej [this message]
2004-01-23 6:46 ` Benjamin Herrenschmidt
2004-01-23 6:54 ` Dave Jones
2004-01-23 7:03 ` Benjamin Herrenschmidt
2004-01-23 11:24 ` John Levon
2004-01-23 13:53 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Ajuub-0000xr-00@hardwired \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®