mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Edward Falk <efalk@google.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add path-oriented proc_mkdir_path() function to /proc
Date: Mon, 10 May 2004 16:14:01 -0700	[thread overview]
Message-ID: <E1BNJyD-0001YR-IU@peregrine.corp.google.com> (raw)

[patch to allow creation of e.g. /proc/foo/bar/ with one function call.]

> Hmm.. Looks like a useful utility function (there's certainly enough deep
> trees in my /proc/sys tree), but I wonder...
> 
> 1) Do we have cases where code should be implementing "it had *better* exist"
> checks?  This may be important if an intermediate directory "should have" been
> created by sysctl or something, and has special permission needs..
> 
> 2) Alternatively, does using this open up accidental collisions where we should
> have checked something *doesnt* exist already, and complain if it does?
> 
> (Feel free to address either one by adding a "Dont do that then" comment ;)

Don't do that, then.  :)

OK, long answer:

1 & 2) are beyond the scope of my patch, but it seems to me that
additional functionality could be added -- perhaps in the form of O_CREAT,
O_EXCL flags -- if demand warranted it.  Perhaps this could be done in
a later patch?

	-ed falk, efalk@google.com

             reply	other threads:[~2004-05-10 23:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-10 23:14 Edward Falk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-05-10 23:22 Edward Falk
2004-05-10 22:09 Edward Falk
2004-05-10 22:39 ` Valdis.Kletnieks
2004-05-10 22:57 ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1BNJyD-0001YR-IU@peregrine.corp.google.com \
    --to=efalk@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®