From: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
To: linux-kernel@vger.kernel.org
Cc: Keir.Fraser@cl.cam.ac.uk, Ian.Pratt@cl.cam.ac.uk
Subject: Buggy RSDP search in ACPI boot-time code
Date: Thu, 17 Jun 2004 10:18:44 +0100 [thread overview]
Message-ID: <E1Bat2k-0004cJ-00@mta1.cl.cam.ac.uk> (raw)
Hi,
I think that the 'high-memory' search range in acpi_find_rsdp() in
arch/i386/kernel/acpi.c (2.4.26) or arch/i386/kernel/acpi/boot.c
(2.6.5) is incorrect.
It is supposed to search 0xE0000-0x100000, but the length field is
incorrectly specified as 0xFFFFF. As in the 'proper' ACPI driver, the
correct length is 0x20000.
The current length means the search grooves on into the kernel itself,
but since the search string "RSD PTR" only appears in the data
section, the search will usually terminate before finding
'itself'. The fact that the search occurs only on 16-byte boundaries
also helps.
Probably best to fix this though. :-) I've already had to for the Xen
VMM (much smaller codebase means that the search string resides within
the too-large search space).
-- Keir Fraser
PS. Please CC me with responses -- I'm not subscribed.
reply other threads:[~2004-06-17 9:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Bat2k-0004cJ-00@mta1.cl.cam.ac.uk \
--to=keir.fraser@cl.cam.ac.uk \
--cc=Ian.Pratt@cl.cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®