From: Bodo Eggert <7eggert@gmx.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] make st seekable again
Date: Thu, 10 Mar 2005 01:43:57 +0100 [thread overview]
Message-ID: <E1D9BmR-00026p-03@be1.7eggert.dyndns.org> (raw)
In-Reply-To: <fa.l4kuq52.e6001g@ifi.uio.no>
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Maw, 2005-03-08 at 17:25, Linux Kernel Mailing List wrote:
>> ChangeSet 1.2030, 2005/03/08 09:25:05-08:00, kai.makisara@kolumbus.fi
>> [PATCH] make st seekable again
>>
>> Apparently `tar' errors out if it cannot perform lseek() against a tape.
>> Work around that in-kernel.
>
> Unfortunately this isn't a good idea. Allowing tar to read the tape
> position makes sense, allowing it to zero the position might but you
> have to do major surgery on the driver first because
>
> 1. It doesn't use ppos
> 2. It doesn't do locking on the ppos at all
>
> Also allowing apps to randomly seek and report "ok" when they are
> backing up to tape and might really need to see the error is not what
> I'd call stable, professional or quality code.
Can the lseek be restricted to seek from 0 to 0 (or even * to 0 aka rewind)?
This would re-enable tar and probably other applications depending on this
API while not giving them false positives.
next parent reply other threads:[~2005-03-10 1:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.i3f7d9s.30m8rg@ifi.uio.no>
[not found] ` <fa.l4kuq52.e6001g@ifi.uio.no>
2005-03-10 0:43 ` Bodo Eggert [this message]
2005-03-10 20:01 ` Willy Tarreau
[not found] <200503081911.j28JBlxi016013@hera.kernel.org>
2005-03-09 20:51 ` Alan Cox
2005-03-09 21:58 ` Kai Makisara
2005-03-09 22:27 ` Alan Cox
2005-03-10 11:49 ` Bill Davidsen
2005-03-10 12:10 ` Arjan van de Ven
2005-03-10 16:43 ` Alan Cox
2005-03-10 16:56 ` Bill Davidsen
2005-03-10 17:13 ` Arjan van de Ven
2005-03-10 17:58 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1D9BmR-00026p-03@be1.7eggert.dyndns.org \
--to=7eggert@gmx.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®