From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] Add comment about dma_supported()
Date: Mon, 11 Apr 2005 23:15:30 +0100 [thread overview]
Message-ID: <E1DL7Bq-0003CF-QF@raistlin.arm.linux.org.uk> (raw)
The ARM dma_supported() is rather basic, and I don't think
it takes into account everything that it should do (eg,
whether the mask agrees with what we'd return for GFP_DMA
allocations). Note this.
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x '*.orig' -x '*.rej' -r orig/include/asm-arm/dma-mapping.h linux/include/asm-arm/dma-mapping.h
--- orig/include/asm-arm/dma-mapping.h Wed Jan 12 10:13:19 2005
+++ linux/include/asm-arm/dma-mapping.h Fri Jun 18 17:56:02 2004
@@ -21,6 +21,9 @@ extern void consistent_sync(void *kaddr,
* properly. For example, if your device can only drive the low 24-bits
* during bus mastering, then you would pass 0x00ffffff as the mask
* to this function.
+ *
+ * FIXME: This should really be a platform specific issue - we should
+ * return false if GFP_DMA allocations may not satisfy the supplied 'mask'.
*/
static inline int dma_supported(struct device *dev, u64 mask)
{
reply other threads:[~2005-04-11 22:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1DL7Bq-0003CF-QF@raistlin.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®