From: Matthew Garrett <mgarrett@chiark.greenend.org.uk>
To: Michael Marineau <marineam@engr.orst.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Radeon acpi vgapost
Date: Sun, 28 Aug 2005 13:50:01 +0100 [thread overview]
Message-ID: <E1E9Mbq-0002WM-00@chiark.greenend.org.uk> (raw)
In-Reply-To: <43111298.80507@engr.orst.edu>
Michael Marineau <marineam@engr.orst.edu> wrote:
> Thses patches resume ATI radeon cards from acpi S3 suspend when using
> radeonfb by reposting the video bios. This is needed to be able to use
> S3 when the framebuffer is enabled.
Please don't make this unconditional. There's no guarantee whatsoever
that the code at c000:0003 does anything useful on a laptop, and it may
actually be harmful in some cases. The sensible approach is to whitelist
it based on DMI entries or provide a sysfs attribute so userspace can
enable/disable it.
How well does this patch deal with multihead? If I have a mixed
radeon/non-radeon system, and the primary head is a non-radeon, won't
this result in the wrong card being POSTed?
--
Matthew Garrett | mjg59-chiark.mail.linux-rutgers.kernel@srcf.ucam.org
next prev parent reply other threads:[~2005-08-28 12:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-28 1:25 Michael Marineau
2005-08-28 1:27 ` [PATCH 1/3] Generic " Michael Marineau
2005-08-28 8:07 ` Pavel Machek
2005-08-28 20:56 ` Jiri Slaby
2005-08-30 10:51 ` Dave Airlie
2005-08-28 1:31 ` [PATCH 2/3] Radeon " Michael Marineau
2005-08-28 1:34 ` [PATCH 3/3] Documentation update for radeonfb Michael Marineau
2005-08-28 5:12 ` [PATCH 0/3] Radeon acpi vgapost Nishanth Aravamudan
2005-08-28 7:44 ` Michael Marineau
2005-08-28 18:08 ` Nishanth Aravamudan
2005-08-28 6:54 ` Manuel Lauss
2005-08-28 7:31 ` [PATCH 4/3] Radeon acpi vgapost only Rv250 (M9) Michael Marineau
2005-08-28 12:50 ` Matthew Garrett [this message]
2005-08-28 17:58 [PATCH 0/3] Radeon acpi vgapost Erik Andrén
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1E9Mbq-0002WM-00@chiark.greenend.org.uk \
--to=mgarrett@chiark.greenend.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marineam@engr.orst.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®