mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bodo Eggert <harvested.in.lkml@7eggert.dyndns.org>
To: Keith Owens <kaos@ocs.com.au>, Ben Dooks <ben-linux@fluff.org>,
	linux-kernel@vger.kernel.org, patch-out@fluff.rog
Subject: Re: [PATCH] scripts - use $OBJDUMP to get correct objdump (cross compile)
Date: Tue, 20 Sep 2005 18:55:22 +0200	[thread overview]
Message-ID: <E1EHlOt-00012f-Au@be1.lrz> (raw)
In-Reply-To: <4OLPC-3NQ-19@gated-at.bofh.it>

Keith Owens <kaos@ocs.com.au> wrote:

> +my $objdump;
> +if (exists($ENV{'OBJDUMP'})) {
> +     $objdump = $ENV{'OBJDUMP'};

Having a typo in the environment shouldn't silently do something different
from what's requested. Use something like

my @objdump = ( (defined $ENV{'OBJDUMP'})? $ENV{'OBJDUMP'} :
                                           "/usr/bin/objdump",
               '-s', '-j');
> +} else {
> +     $objdump = 'objdump';
> +}
> +$objdump .= ' -s -j .comment';

Having a space as the option delimiter will break if the path to objdump
contains a space. Therefore you'll need to use an array.

-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

       reply	other threads:[~2005-09-20 16:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4OB3R-5gu-13@gated-at.bofh.it>
     [not found] ` <4OLPC-3NQ-19@gated-at.bofh.it>
2005-09-20 16:55   ` Bodo Eggert [this message]
2005-09-20 18:43     ` Valdis.Kletnieks
2005-09-20 19:03       ` Bodo Eggert
2005-09-19 21:06 Ben Dooks
2005-09-20  8:28 ` Keith Owens
2005-09-20 14:39   ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1EHlOt-00012f-Au@be1.lrz \
    --to=harvested.in.lkml@7eggert.dyndns.org \
    --cc=7eggert@gmx.de \
    --cc=ben-linux@fluff.org \
    --cc=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patch-out@fluff.rog \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®