mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bodo Eggert <harvested.in.lkml@7eggert.dyndns.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>,
	Ben Dooks <ben-linux@fluff.org>,
	"Randy.Dunlap" <rdunlap@xenotime.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] release_resource() check for NULL resource
Date: Wed, 05 Oct 2005 00:31:07 +0200	[thread overview]
Message-ID: <E1EMvJT-0001Jd-5v@be1.lrz> (raw)
In-Reply-To: <4TxWv-1xD-37@gated-at.bofh.it>

Pekka Enberg <penberg@cs.helsinki.fi> wrote:

> static int driver_init(void)
> {
>      dev->resource1 = request_region(...);
>      if (!dev->resource1)
>              goto failed;

> failed:
>      driver_release(dev);

> static void driver_release(struct device * dev)
> {
>      release_resource(dev->resource1);
>      release_resource(dev->resource2);

If the dev struct* isn't properly initialized, it will try to free a random
resource.
-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

       reply	other threads:[~2005-10-04 22:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4TfvY-8ix-27@gated-at.bofh.it>
     [not found] ` <4Tg8u-Bn-15@gated-at.bofh.it>
     [not found]   ` <4Tv7u-5Hd-15@gated-at.bofh.it>
     [not found]     ` <4TvB0-6wD-3@gated-at.bofh.it>
     [not found]       ` <4TvB7-6wD-5@gated-at.bofh.it>
     [not found]         ` <4TxWv-1xD-37@gated-at.bofh.it>
2005-10-04 22:31           ` Bodo Eggert [this message]
2005-10-05  9:06             ` Russell King
2005-10-02 17:03 Ben Dooks
2005-10-02 17:39 ` Randy.Dunlap
2005-10-03  9:48   ` Ben Dooks
2005-10-03  9:59     ` Jesper Juhl
2005-10-03 10:04       ` Russell King
2005-10-03 12:43         ` Pekka Enberg
2005-10-03 12:49           ` Russell King
2005-10-03 12:54             ` Pekka J Enberg
2005-10-03 13:00               ` Russell King
2005-10-03 13:12                 ` Pekka J Enberg
2005-10-03 13:42                   ` Russell King
2005-10-03 13:42           ` Al Viro
2005-10-03 14:57             ` Pekka Enberg
2005-10-04  2:15         ` Randy.Dunlap
     [not found]   ` <5dc44ec70510031959w1f4adfcbh395535ade34a357d@mail.gmail.com>
2005-10-04  3:00     ` Diego de Estrada
2005-10-04  3:28     ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1EMvJT-0001Jd-5v@be1.lrz \
    --to=harvested.in.lkml@7eggert.dyndns.org \
    --cc=7eggert@gmx.de \
    --cc=ben-linux@fluff.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®