From: Matthew Wilcox <matthew@wil.cx>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: Matthew Wilcox <matthew@wil.cx>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: [PATCH 4/5] Initialise pci_dev->irq correctly
Date: Tue, 22 Nov 2005 00:19:10 -0500 [thread overview]
Message-ID: <E1EeQYg-00055v-SX@localhost.localdomain> (raw)
If the Interrupt Pin is 0, initialise the device's irq to NO_IRQ instead of
leaving it unset.
Signed-off-by: Matthew Wlcox <matthew@wil.cx>
---
drivers/pci/probe.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
applies-to: 3175f6d926ef8ff55ee1fd96364d5b3ed430fb38
4ec4e15bcdd7401cf1fb19ef1cd4f64eb064a4c7
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index fce2cb2..652095c 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -571,9 +571,12 @@ static void pci_read_irq(struct pci_dev
unsigned char irq;
pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &irq);
- if (irq)
+ if (irq) {
pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
- dev->irq = irq;
+ dev->irq = irq;
+ } else {
+ dev->irq = NO_IRQ;
+ }
}
/**
---
0.99.8.GIT
reply other threads:[~2005-11-22 5:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1EeQYg-00055v-SX@localhost.localdomain \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®