mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bodo Eggert <harvested.in.lkml@7eggert.dyndns.org>
To: Andrew Morton <akpm@osdl.org>,
	Dirk Henning Gerdes <mail@dirk-gerdes.de>,
	axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] linux-2.6-block: deactivating pagecache for  benchmarks
Date: Sat, 03 Dec 2005 03:05:34 +0100	[thread overview]
Message-ID: <E1EiMmN-0001a6-I7@be1.lrz> (raw)
In-Reply-To: <5f7UE-3FH-13@gated-at.bofh.it>

Andrew Morton <akpm@osdl.org> wrote:

> +             .procname       = "drop-pagecache",
> +             .data           = NULL,
> +             .maxlen         = sizeof(int),
> +             .mode           = 0644,

1) Shouldn't this be a trigger? Reading from a trigger doesn't make sense,
   especially when triggering on a read.  .mode = 0200?


2) If you pass an int, wouldn't a bitmask selecting what to free make sense?
   (off cause -1 == everything)
   Maybe this would be overengineered.

-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.

  parent reply	other threads:[~2005-12-03  2:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5f08L-Um-413@gated-at.bofh.it>
2005-12-01 22:48 ` Bodo Eggert
     [not found] ` <5f7UE-3FH-13@gated-at.bofh.it>
2005-12-03  2:05   ` Bodo Eggert [this message]
2005-12-01 13:17 Dirk Henning Gerdes
2005-12-01 13:29 ` Arjan van de Ven
2005-12-01 13:43   ` Dirk Henning Gerdes
2005-12-01 14:36 ` Jens Axboe
2005-12-02  1:25 ` Andrew Morton
2005-12-02  1:34   ` Jeff Garzik
2005-12-02 19:19     ` Badari Pulavarty
2005-12-02 19:17   ` Badari Pulavarty
2005-12-02 21:24   ` Badari Pulavarty
2005-12-02 21:44     ` Andrew Morton
2005-12-02 22:33       ` Badari Pulavarty
2005-12-05  2:13   ` Rob Landley
2005-12-05 16:20     ` Lee Revell
2005-12-05 17:28       ` Rob Landley
2005-12-05 16:54   ` Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1EiMmN-0001a6-I7@be1.lrz \
    --to=harvested.in.lkml@7eggert.dyndns.org \
    --cc=7eggert@gmx.de \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@dirk-gerdes.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®