mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sanjoy Mahajan <sanjoy@mrao.cam.ac.uk>
To: "Yu, Luming" <luming.yu@intel.com>
Cc: linux-kernel@vger.kernel.org,
	"Linus Torvalds" <torvalds@osdl.org>,
	"Andrew Morton" <akpm@osdl.org>,
	"Tom Seeley" <redhat@tomseeley.co.uk>,
	"Dave Jones" <davej@redhat.com>,
	"Jiri Slaby" <jirislaby@gmail.com>,
	michael@mihu.de, mchehab@infradead.org,
	"Brian Marete" <bgmarete@gmail.com>,
	"Ryan Phillips" <rphillips@gentoo.org>,
	gregkh@suse.de, "Brown, Len" <len.brown@intel.com>,
	linux-acpi@vger.kernel.org, "Mark Lord" <lkml@rtr.ca>,
	"Randy Dunlap" <rdunlap@xenotime.net>,
	jgarzik@pobox.com, "Duncan" <1i5t5.duncan@cox.net>,
	"Pavlik Vojtech" <vojtech@suse.cz>,
	"Meelis Roos" <mroos@linux.ee>
Subject: Re: 2.6.16-rc5: known regressions [TP 600X S3, vanilla DSDT]
Date: Wed, 22 Mar 2006 02:00:05 -0500	[thread overview]
Message-ID: <E1FLxK9-000243-Cc@approximate.corpus.cam.ac.uk> (raw)
In-Reply-To: Your message of "Wed, 22 Mar 2006 09:34:53 +0800." <3ACA40606221794F80A5670F0AF15F840B417BB4@pdsmsx403>

I tried the following kernels (all with only THM0):

1. No other changes: It hangs, as before and as expected.

2. Commented out a large chunk of the UPDT() method:

diff -r ac2b38909dfa -r c431c477d3b6 dsdt/600x.dsl
--- a/dsdt/600x.dsl	Tue Mar 21 17:12:47 2006 -0500
+++ b/dsdt/600x.dsl	Wed Mar 22 00:22:21 2006 -0500
@@ -4132,19 +4132,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, 
                                 If (Acquire (I2CM, 0x0064)) {}
                                 Else
                                 {
-                                    Store (I2RB (Zero, 0x01, 0x04), Local7)
-                                    If (Local7)
-                                    {
-                                        Fatal (0x01, 0x80000003, Local7)
-                                    }
-                                    Else
-                                    {
-                                        Store (HBS0, TMP0)
-                                        Store (HBS2, TMP2)
-                                        Store (HBS6, TMP6)
-                                        Store (HBS7, TMP7)
-                                    }
-
                                     Release (I2CM)
                                 }
                             }

So now it just grabs and releases the I2CM lock.  

This kernel hung on the first sleep, but I couldn't reproduce that
behavior.  I tried two more boots, and each time it never hung.  I even
thought it might depend on the result of previous boots, so I tried
kernel #1 again and got the same hang, and then tried #2.  But it still
wouldn't hang.  So I went back through the serial console logs to check
whether I was hallucinating, and I was not.  This kernel had indeed hung
on the first sleep, but only the first time I booted it.

So I'm going to assume that it's okay, and that if it isn't okay, it's
because of another, more intermitten bug.

3. Commented out EC0.UPDT() call in THM0._THM, and this kernel was fine,
   which is how it behaved a couple days ago, and is what I expected.

I'm about to try a smaller change (continuing the bisect):

diff -r ac2b38909dfa -r f10a309b8385 dsdt/600x.dsl
--- a/dsdt/600x.dsl	Tue Mar 21 17:12:47 2006 -0500
+++ b/dsdt/600x.dsl	Wed Mar 22 01:44:12 2006 -0500
@@ -4137,13 +4137,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, 
                                     {
                                         Fatal (0x01, 0x80000003, Local7)
                                     }
-                                    Else
-                                    {
-                                        Store (HBS0, TMP0)
-                                        Store (HBS2, TMP2)
-                                        Store (HBS6, TMP6)
-                                        Store (HBS7, TMP7)
-                                    }
 
                                     Release (I2CM)
                                 }


After that bisection there's not much more to change in UPDT().
However, I can drill down into I2RB() because of this line in UPDT():

    Store (I2RB (Zero, 0x01, 0x04), Local7)

But I have no idea what's safe to experiment with in I2RB():

                    Method (I2RB, 3, NotSerialized)
                    {
                        Store (Arg0, HCSL)
                        Store (ShiftLeft (Arg1, 0x01), HMAD)
                        Store (Arg2, HMCM)
                        Store (0x0B, HMPR)
                        Return (CHKS ())
                    }


All those lines look like tricky hardware manipulations.

By the way, which debug_{level,layer} settings will show the lines of
the human-readable DSDT as they are executed?

-Sanjoy

  reply	other threads:[~2006-03-22  7:00 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-22  1:34 Yu, Luming
2006-03-22  7:00 ` Sanjoy Mahajan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-05-23 13:29 Yu, Luming
2006-05-23 17:12 ` Sanjoy Mahajan
2006-04-05  3:03 Yu, Luming
2006-03-24  1:31 Yu, Luming
2006-04-04  6:49 ` Sanjoy Mahajan
2006-03-23  9:10 Yu, Luming
2006-03-23 19:19 ` Sanjoy Mahajan
2006-03-23  4:46 Yu, Luming
2006-03-23  6:25 ` Sanjoy Mahajan
2006-03-22  7:28 Yu, Luming
2006-03-22 14:16 ` Sanjoy Mahajan
2006-03-22  4:58 Yu, Luming
2006-03-22  5:13 ` Sanjoy Mahajan
2006-03-24  1:17 ` Sanjoy Mahajan
2006-03-22  1:30 Yu, Luming
2006-03-22  4:35 ` Sanjoy Mahajan
2006-03-22  7:15 ` Sanjoy Mahajan
2006-03-21  9:11 Yu, Luming
2006-03-21 20:37 ` Sanjoy Mahajan
2006-03-21 22:09 ` Sanjoy Mahajan
2006-03-21  1:38 Yu, Luming
2006-03-21  7:27 ` Sanjoy Mahajan
2006-03-21  8:47 ` Sanjoy Mahajan
2006-03-19  4:12 Yu, Luming
2006-03-19 14:33 ` Sanjoy Mahajan
2006-03-20  6:39 ` Sanjoy Mahajan
2006-03-18 17:08 Yu, Luming
2006-03-18 20:12 ` Sanjoy Mahajan
2006-03-18 16:37 Yu, Luming
2006-03-18 17:03 ` Sanjoy Mahajan
2006-03-18 15:58 Yu, Luming
2006-03-18 16:27 ` Sanjoy Mahajan
2006-03-18 15:10 Yu, Luming
2006-03-18 15:48 ` Sanjoy Mahajan
2006-03-18 13:24 Yu, Luming
2006-03-18 14:37 ` Sanjoy Mahajan
2006-03-18  2:02 Yu, Luming
2006-03-18  7:23 ` Sanjoy Mahajan
2006-03-17  7:50 Yu, Luming
2006-03-17 18:43 ` Sanjoy Mahajan
2006-03-17  6:57 Yu, Luming
2006-03-17  7:11 ` Sanjoy Mahajan
2006-03-17  7:32 ` Sanjoy Mahajan
2006-03-17  1:17 Yu, Luming
2006-03-17  6:28 ` Sanjoy Mahajan
2006-03-16  8:18 Yu, Luming
2006-03-16 15:15 ` Sanjoy Mahajan
2006-03-16  7:28 Yu, Luming
2006-03-16  7:57 ` Sanjoy Mahajan
2006-03-16  6:41 Yu, Luming
2006-03-16  6:54 ` Sanjoy Mahajan
2006-03-16  7:14 ` Sanjoy Mahajan
2006-03-15  8:02 Yu, Luming
2006-03-16  0:03 ` Sanjoy Mahajan
2006-03-16  5:47 ` Sanjoy Mahajan
2006-03-16  6:46 ` Sanjoy Mahajan
2006-03-15  6:47 Yu, Luming
2006-03-15  7:06 ` Sanjoy Mahajan
2006-03-15  6:25 Yu, Luming
2006-03-15  6:16 Yu, Luming
2006-03-15  6:35 ` Sanjoy Mahajan
2006-03-15  1:46 Yu, Luming
2006-03-15  5:40 ` Sanjoy Mahajan
2006-03-15  5:57 ` Sanjoy Mahajan
2006-03-14  1:48 Yu, Luming
2006-03-14  8:28 ` Sanjoy Mahajan
2006-03-13  8:35 Yu, Luming
2006-03-13 15:21 ` Sanjoy Mahajan
2006-03-13  4:51 Yu, Luming
2006-03-13  7:28 ` Sanjoy Mahajan
2006-03-13  2:00 Yu, Luming
2006-03-13  4:38 ` Sanjoy Mahajan
2006-03-10  6:46 Yu, Luming
2006-03-10 13:27 ` Sanjoy Mahajan
2006-03-10 13:36 ` Sanjoy Mahajan
2006-03-10  6:12 Yu, Luming
2006-03-10  6:27 ` Sanjoy Mahajan
2006-02-27  9:04 2.6.16-rc5: known regressions Yu, Luming
2006-03-10  5:26 ` 2.6.16-rc5: known regressions [TP 600X S3, vanilla DSDT] Sanjoy Mahajan
2006-05-19 13:44   ` Thomas Renninger
2006-05-21  0:12     ` Sanjoy Mahajan
2006-05-21  0:40       ` Carl-Daniel Hailfinger
2006-05-21  1:30         ` Joshua Hudson
2006-05-21  3:53           ` Lee Revell
2006-05-22  9:55       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1FLxK9-000243-Cc@approximate.corpus.cam.ac.uk \
    --to=sanjoy@mrao.cam.ac.uk \
    --cc=1i5t5.duncan@cox.net \
    --cc=akpm@osdl.org \
    --cc=bgmarete@gmail.com \
    --cc=davej@redhat.com \
    --cc=gregkh@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=jirislaby@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@rtr.ca \
    --cc=luming.yu@intel.com \
    --cc=mchehab@infradead.org \
    --cc=michael@mihu.de \
    --cc=mroos@linux.ee \
    --cc=rdunlap@xenotime.net \
    --cc=redhat@tomseeley.co.uk \
    --cc=rphillips@gentoo.org \
    --cc=torvalds@osdl.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®