From: Miklos Szeredi <miklos@szeredi.hu>
To: trond.myklebust@fys.uio.no
Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] locks: don't unnecessarily fail posix lock operations
Date: Fri, 31 Mar 2006 21:25:14 +0200 [thread overview]
Message-ID: <E1FPPFC-0005mL-00@dorka.pomaz.szeredi.hu> (raw)
In-Reply-To: <1143829641.8085.7.camel@lade.trondhjem.org> (message from Trond Myklebust on Fri, 31 Mar 2006 13:27:21 -0500)
> NACK.
>
> This changes the behaviour of F_UNLCK. Currently, if the allocation
> fails, the inode locking state remains unchanged. With your change, an
> unlock request may end up unlocking part of the inode, but not the rest.
No, look more closer. There are two cases:
- some locks are partially or completely removed
- the unlock splits an existing lock in two.
In the first case no new locks are needed. In the second, no locks
are modified prior to the check.
Miklos
next prev parent reply other threads:[~2006-03-31 19:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 17:26 [PATCH 0/4] locks: cleanups and fixes Miklos Szeredi
2006-03-31 17:28 ` [PATCH 1/4] locks: export raw __posix_lock_file() interface Miklos Szeredi
2006-03-31 17:30 ` [PATCH 2/4] locks: don't unnecessarily fail posix lock operations Miklos Szeredi
2006-03-31 18:27 ` Trond Myklebust
2006-03-31 18:44 ` Trond Myklebust
2006-03-31 19:31 ` Miklos Szeredi
2006-03-31 19:25 ` Miklos Szeredi [this message]
2006-03-31 19:40 ` Trond Myklebust
2006-03-31 19:46 ` Miklos Szeredi
2006-04-01 4:30 ` Trond Myklebust
2006-04-01 6:39 ` Miklos Szeredi
2006-03-31 17:31 ` [PATCH 3/4] locks: don't do unnecessary allocations Miklos Szeredi
2006-03-31 17:33 ` [PATCH 4/4] locks: clean up locks_remove_posix() Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1FPPFC-0005mL-00@dorka.pomaz.szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®