mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: torvalds@linux-foundation.org
Cc: jacmet@sunsite.dk, dhowells@redhat.com, k.shutemov@gmail.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] Include <asm/a.out.h> in fs/exec.c only for Alpha.
Date: Mon, 16 Jun 2008 12:11:54 +0100	[thread overview]
Message-ID: <E1K8Eex-0002GT-LV@pmac.infradead.org> (raw)
In-Reply-To: <87abhl7eqo.fsf@macbook.be.48ers.dk>

We only need it for the /sbin/loader hack for OSF/1 executables, and we
don't want to include it otherwise.

While we're at it, remove the redundant '&& CONFIG_ARCH_SUPPORTS_AOUT'
in the ifdef around that code. It's already dependent on __alpha__, and
CONFIG_ARCH_SUPPORTS_AOUT is hard-coded to 'y' there.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
---
 fs/exec.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/fs/exec.c b/fs/exec.c
index 9448f1b..da94a6f 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -26,7 +26,6 @@
 #include <linux/file.h>
 #include <linux/fdtable.h>
 #include <linux/mman.h>
-#include <linux/a.out.h>
 #include <linux/stat.h>
 #include <linux/fcntl.h>
 #include <linux/smp_lock.h>
@@ -61,6 +60,11 @@
 #include <linux/kmod.h>
 #endif
 
+#ifdef __alpha__
+/* for /sbin/loader handling in search_binary_handler() */
+#include <linux/a.out.h>
+#endif
+
 int core_uses_pid;
 char core_pattern[CORENAME_MAX_SIZE] = "core";
 int suid_dumpable = 0;
@@ -1155,7 +1159,7 @@ int search_binary_handler(struct linux_binprm *bprm,struct pt_regs *regs)
 {
 	int try,retval;
 	struct linux_binfmt *fmt;
-#if defined(__alpha__) && defined(CONFIG_ARCH_SUPPORTS_AOUT)
+#ifdef __alpha__
 	/* handle /sbin/loader.. */
 	{
 	    struct exec * eh = (struct exec *) bprm->buf;
-- 
1.5.5.1


  reply	other threads:[~2008-06-16 13:22 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-15 21:07 [PATCH] export linux/a.out.h Peter Korsgaard
2008-06-15 21:32 ` David Woodhouse
2008-06-16  8:29   ` [PATCH v2] " Peter Korsgaard
2008-06-16 12:01     ` David Woodhouse
2008-06-16 12:17       ` Adrian Bunk
2008-06-16 12:26         ` David Woodhouse
2008-06-17  8:42           ` architectures with ARCH_SUPPORTS_AOUT but no binfmt_aout Adrian Bunk
2008-06-17  9:46             ` David Woodhouse
2008-06-17 10:11               ` Adrian Bunk
2008-06-17 10:18                 ` David Woodhouse
2008-06-17 10:24                   ` Adrian Bunk
2008-06-17 11:28                 ` David Woodhouse
2008-06-17 12:23                   ` Sam Ravnborg
2008-06-17 12:29                     ` David Woodhouse
2008-06-17 12:37                       ` Sam Ravnborg
2008-06-17 12:54                         ` David Woodhouse
2008-06-22  9:49                   ` Adrian Bunk
2008-06-22 11:40                     ` David Woodhouse
2008-06-22 23:53                       ` David McCullough
2008-06-24 11:46                       ` Adrian Bunk
2008-06-27 16:27                         ` Jeff Dike
2008-06-27 21:12               ` [2.6 patch] remove unused asm/a.out.h files Adrian Bunk
2008-09-05 16:27               ` [PATCH 1/2] Remove redundant CONFIG_ARCH_SUPPORTS_AOUT David Woodhouse
2008-09-05 16:28                 ` Kyle McMartin
2008-09-05 17:17                   ` [PATCH 3/2] Remove asm/a.out.h files for all architectures without a.out support David Woodhouse
2008-09-05 17:17                   ` [PATCH 1/2] Remove redundant CONFIG_ARCH_SUPPORTS_AOUT David Woodhouse
2008-09-05 16:27               ` [PATCH 2/2] Introduce HAVE_AOUT symbol to remove hard-coded arch list for BINFMT_AOUT David Woodhouse
2008-06-17 11:28             ` architectures with ARCH_SUPPORTS_AOUT but no binfmt_aout Matthew Wilcox
2008-06-24  4:15             ` Paul Mundt
2008-06-16 13:48         ` [PATCH v2] export linux/a.out.h David Howells
2008-06-16 15:47           ` David Woodhouse
2008-06-16 12:20       ` Peter Korsgaard
2008-06-16 11:11         ` David Woodhouse [this message]
2008-06-16 11:18         ` [PATCH 2/4] Remove last traces of a.out support from ELF loader David Woodhouse
2008-06-16 11:18         ` [PATCH 3/4] Remove #ifdef CONFIG_ARCH_SUPPORTS_AOUT from <linux/a.out.h> David Woodhouse
2008-06-16 11:24         ` [PATCH 4/4] Export <linux/a.out.h> to userspace again David Woodhouse
2008-06-16 13:22         ` [PATCH v2] export linux/a.out.h David Woodhouse
2008-06-16 14:40       ` Andi Kleen
2008-06-16 15:15         ` David Woodhouse
2008-06-15 22:33 ` [PATCH] " Arjan van de Ven
2008-06-16  7:03   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1K8Eex-0002GT-LV@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=dhowells@redhat.com \
    --cc=jacmet@sunsite.dk \
    --cc=k.shutemov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®