mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Collins <ben.collins@canonical.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH 6/7] pm: Config option to disable handling of console during suspend/resume
Date: Sun, 20 Jul 2008 21:48:28 -0400	[thread overview]
Message-ID: <E1KKl4J-00068V-6f@swissweb.swissdisk.com> (raw)
In-Reply-To: <24762.90.138.930.038.1036103001.ben.collins@canonical.com>

Config option allows userspace to handle console during suspend/resume
instead of the kernel.

Signed-off-by: Ben Collins <ben.collins@canonical.com>
---
 kernel/power/Kconfig   |   15 +++++++++++++++
 kernel/power/console.c |    4 ++++
 2 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
index b45da40..6855299 100644
--- a/kernel/power/Kconfig
+++ b/kernel/power/Kconfig
@@ -105,6 +105,21 @@ config SUSPEND_FREEZER
 
 	  Turning OFF this setting is NOT recommended! If in doubt, say Y.
 
+config PM_DISABLE_CONSOLE
+	bool "Disable Power Management messing with the active console"
+	depends on PM
+	default n
+	---help---
+	  By default, PM will take over the active console (generally, this means
+	  switching to the console when suspending from X). This can at times cause
+	  problems, especially if userspace suspend scripts try to do things with
+	  the console before or after suspending (e.g. calling vbestate).
+
+	  To work around this, enable this option so that PM will not handle the
+	  console.
+
+	  If unsure, say N.
+
 config HIBERNATION
 	bool "Hibernation (aka 'suspend to disk')"
 	depends on PM && SWAP && ARCH_HIBERNATION_POSSIBLE
diff --git a/kernel/power/console.c b/kernel/power/console.c
index b8628be..8b9706f 100644
--- a/kernel/power/console.c
+++ b/kernel/power/console.c
@@ -33,6 +33,7 @@ EXPORT_SYMBOL(pm_set_vt_switch);
 
 int pm_prepare_console(void)
 {
+#ifndef CONFIG_PM_DISABLE_CONSOLE
 	acquire_console_sem();
 
 	if (disable_vt_switch) {
@@ -66,11 +67,13 @@ int pm_prepare_console(void)
 	}
 	orig_kmsg = kmsg_redirect;
 	kmsg_redirect = SUSPEND_CONSOLE;
+#endif
 	return 0;
 }
 
 void pm_restore_console(void)
 {
+#ifndef CONFIG_PM_DISABLE_CONSOLE
 	acquire_console_sem();
 	if (disable_vt_switch) {
 		release_console_sem();
@@ -79,5 +82,6 @@ void pm_restore_console(void)
 	set_console(orig_fgconsole);
 	release_console_sem();
 	kmsg_redirect = orig_kmsg;
+#endif
 }
 #endif
-- 
1.5.4.3


  parent reply	other threads:[~2008-07-21  4:42 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 15:57 [PATCH 0/7] Patches from Ubuntu kernel tree Ben Collins
2008-01-02 15:57 ` [PATCH 1/7] netfilter: Export ip6t_mh.h and xt_quota.h for iptables build Tim Gardner
2008-07-22  8:55   ` Jan Engelhardt
2008-07-22 10:45   ` Patrick McHardy
2008-01-18 18:21 ` [PATCH 2/7] ata: blacklist FUJITSU MHW2160BH PL Chuck Short
2008-07-31  5:45   ` Jeff Garzik
2008-07-20 21:08 ` [PATCH 4/7] irda: Default to dongle type 9 on IBM hardware Matthew Garrett
2008-07-21  5:29   ` Marcel Holtmann
2008-07-21 17:40     ` [PATCH 4/7] nsc-ircc: " Ben Collins
2008-07-29  2:46       ` Andrew Morton
2008-07-30  1:44         ` Matthew Garrett
2008-07-30  2:16           ` Andrew Morton
2008-07-30  5:11             ` Matthew Garrett
2008-07-30 14:17               ` Ben Collins
2008-07-20 21:44 ` [PATCH 7/7] HID: Add quirks for fourth generation MacBooks (4,1) Alexandre Karpenko
2008-07-21  1:45 ` [PATCH 3/7] bluetooth: Add quirks for a few hci_usb devices Ben Collins
2008-07-21  5:08   ` Marcel Holtmann
2008-07-21  5:54     ` Ben Collins
2008-07-21 16:00     ` Ben Collins
2008-07-21 23:30       ` Marcel Holtmann
2008-07-21  1:48 ` Ben Collins [this message]
2008-07-29  3:33   ` [PATCH 6/7] pm: Config option to disable handling of console during suspend/resume Greg KH
2008-07-29 21:15     ` Rafael J. Wysocki
2008-07-29 21:51       ` Ben Collins
2008-07-29 22:18         ` Rafael J. Wysocki
2008-07-30  4:47         ` Greg KH
2008-07-30 14:20           ` Ben Collins
2008-08-04  6:28             ` Pavel Machek
2008-08-07 21:23               ` Ben Collins
2008-08-07 21:43                 ` Rafael J. Wysocki
2008-07-21  1:54 ` [PATCH 5/7] [airprime] Add support for more devices Ben Collins
2008-07-29  2:58   ` Andrew Morton
2008-07-29  3:17     ` Greg KH
2008-07-29  3:30       ` Greg KH
2008-07-29 14:20         ` Ben Collins
2008-07-29 15:53           ` Kevin Lloyd
2008-07-29  3:35 ` [PATCH 0/7] Patches from Ubuntu kernel tree Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1KKl4J-00068V-6f@swissweb.swissdisk.com \
    --to=ben.collins@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®