From: Cliff Wickman <cpw@sgi.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, tj@kernel.org
Subject: [PATCH] x86: UV cleanup
Date: Thu, 29 Jan 2009 13:39:16 -0600 [thread overview]
Message-ID: <E1LScjM-00073R-Cu@eag09.americas.sgi.com> (raw)
From: Cliff Wickman <cpw@sgi.com>
This patch tweaks a couple things:
- uv_flush_tlb_others()
the WARN_ON(!in_atomic()); fails if CONFIG_PREEMPT is not enabled
The #ifdef may not be the right fix. The fix is probably in the
in_atomic macro, but I'm not sure what in_atomic() should return
if CONFIG_PREEMPT is turned off. I tested making it return 1 in that
case, but that yielded tons of warnings.
The simpler fix for tlb_uv.c would be to just drop the WARN_ON.
- uv_flush_send_and_wait() should return a pointer if the broadcast
remote tlb shootdown requests fail. That causes the conventional IPI
method of shootdown to be used.
Diffed against 2.6.29-rc2
(Ingo's tree)
Signed-off-by: Cliff Wickman <cpw@sgi.com>
---
arch/x86/kernel/tlb_uv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux/arch/x86/kernel/tlb_uv.c
===================================================================
--- linux.orig/arch/x86/kernel/tlb_uv.c
+++ linux/arch/x86/kernel/tlb_uv.c
@@ -259,7 +259,7 @@ const struct cpumask *uv_flush_send_and_
* the cpu's, all of which are still in the mask.
*/
__get_cpu_var(ptcstats).ptc_i++;
- return 0;
+ return flush_mask;
}
/*
@@ -316,7 +316,9 @@ const struct cpumask *uv_flush_tlb_other
int locals = 0;
struct bau_desc *bau_desc;
+#ifdef CONFIG_PREEMPT
WARN_ON(!in_atomic());
+#endif
cpumask_andnot(flush_mask, cpumask, cpumask_of(cpu));
next reply other threads:[~2009-01-29 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 19:39 Cliff Wickman [this message]
2009-01-29 20:35 ` Ingo Molnar
2009-01-29 21:30 ` Cliff Wickman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LScjM-00073R-Cu@eag09.americas.sgi.com \
--to=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®