mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: linux-kernel@vger.kernel.org
Cc: Matthew Wilcox <willy@linux.intel.com>
Subject: No NCQ support on X61s Ultrabay?  (Intel ICH8 SATA controller question)
Date: Wed, 29 Apr 2009 22:07:14 -0400	[thread overview]
Message-ID: <E1LzLgA-0004j6-9W@closure.thunk.org> (raw)

I was taking a look at why I can't get NCQ working on the Ultrabay drive
on the X61s Thinkpad (which is a big deal if you're using the X25-M
SSD):

[ 4563.614247] ata4.00: 390721968 sectors, multi 16: LBA48 NCQ (depth 0/32)
                                                                ^^^^^^^

which as near as I can tell is because ATA_FLAG_NCQ isn't set in struct
ata_port->flag.  This looks like it should be set to ata_piix.c if the
controller supports NCQ --- but ata_piix.c doesn't set ATA_FLAG_NCQ at
all.  However, this web page:

	http://www.intel.com/support/chipsets/imst/sb/CS-012304.htm

Seems to imply the 82801HBM/HEM SATA controller from the ICH8M/ICHM8-E
supports AHCI and NCQ, and this is the controller which is in the X61s
laptop.

So I wonder if it's safe to simply add ATA_FLAG_NCQ to ata_piix.c or
not?  Can someone who's more familiar with Intel's ICH8 SATA controller
comment on whether this would be a safe thing to do?

Thanks,

						- Ted

             reply	other threads:[~2009-04-30  2:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-30  2:07 Theodore Ts'o [this message]
2009-04-30  2:19 ` Tejun Heo
2009-04-30  2:27 ` Jeff Garzik
2009-04-30  7:33   ` Alex Buell
2009-04-30  7:45     ` Tejun Heo
2009-04-30 13:47       ` Alan Cox
2009-04-30 15:35         ` Matthew Wilcox
2009-04-30 15:47           ` Matthew Garrett
2009-05-01  1:49             ` Robert Hancock
2009-05-03  2:07               ` Tejun Heo
2009-05-03 20:50                 ` Robert Hancock
2009-05-03 22:35                   ` Jason Riedy
2009-04-30 11:34     ` Theodore Tso
2009-04-30 11:38       ` Theodore Tso
2009-05-01  1:51         ` Robert Hancock
2009-05-01  2:51           ` Theodore Tso
2009-05-01  4:21             ` Robert Hancock
2009-05-01 11:35               ` Matthew Wilcox
2009-05-01 13:14                 ` Theodore Tso
2009-05-01 13:59                   ` Matthew Garrett
2009-05-01 14:09                   ` Matthew Wilcox
2009-04-30 15:42       ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1LzLgA-0004j6-9W@closure.thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®